Merge pull request #1755 from flintlib/fmpz_mod3

Further fmpz_mod_mat cleanup

Author: fredrik-johansson

doc/source/fmpz_mat.rst

@@ -1147,21 +1147,6 @@ Row reduction
     ``rank``, returns 1 if so and 0 otherwise.
 
 
-Modular gaussian elimination
---------------------------------------------------------------------------------
-
-
-.. function:: slong fmpz_mat_rref_mod(slong * perm, fmpz_mat_t A, const fmpz_t p)
-
-    Uses fraction-free Gauss-Jordan elimination to set ``A``
-    to its reduced row echelon form and returns the rank of ``A``.
-    All computations are done modulo p.
-
-    Pivot elements are chosen with ``fmpz_mat_find_pivot_any``.
-    If ``perm`` is non-``NULL``, the permutation of
-    rows in the matrix will also be applied to ``perm``.
-
-
 Strong echelon form and Howell form
 --------------------------------------------------------------------------------
 

doc/source/fmpz_mod_mat.rst

@@ -262,13 +262,10 @@ Gaussian elimination
 --------------------------------------------------------------------------------
 
 
-.. function:: slong fmpz_mod_mat_rref(slong * perm, fmpz_mod_mat_t mat, const fmpz_mod_ctx_t ctx)
+.. function:: slong fmpz_mod_mat_rref(fmpz_mod_mat_t res, const fmpz_mod_mat_t mat, const fmpz_mod_ctx_t ctx)
 
-    Uses Gauss-Jordan elimination to set ``mat`` to its reduced row echelon
-    form and returns the rank of ``mat``.
-
-    If ``perm`` is non-``NULL``, the permutation of
-    rows in the matrix will also be applied to ``perm``.
+    Sets ``res`` to the reduced row echelon form of ``mat``
+    and returns the rank.
 
     The modulus is assumed to be prime.
 

doc/source/fq_default_mat.rst

@@ -338,9 +338,9 @@ Reduced row echelon form
 --------------------------------------------------------------------------------
 
 
-.. function:: slong fq_default_mat_rref(fq_default_mat_t A, const fq_default_ctx_t ctx)
+.. function:: slong fq_default_mat_rref(fq_default_mat_t B, const fq_default_mat_t A, const fq_default_ctx_t ctx)
 
-    Puts `A` in reduced row echelon form and returns the rank of `A`.
+    Puts `B` in reduced row echelon form and returns the rank of `A`.
 
     The rref is computed by first obtaining an unreduced row echelon
     form via LU decomposition and then solving an additional

doc/source/fq_mat.rst

@@ -377,9 +377,9 @@ Reduced row echelon form
 --------------------------------------------------------------------------------
 
 
-.. function:: slong fq_mat_rref(fq_mat_t A, const fq_ctx_t ctx)
+.. function:: slong fq_mat_rref(fq_mat_t B, const fq_mat_t A, const fq_ctx_t ctx)
 
-    Puts `A` in reduced row echelon form and returns the rank of `A`.
+    Puts `B` in reduced row echelon form and returns the rank of `A`.
 
     The rref is computed by first obtaining an unreduced row echelon
     form via LU decomposition and then solving an additional

doc/source/fq_nmod_mat.rst

@@ -376,9 +376,9 @@ Reduced row echelon form
 --------------------------------------------------------------------------------
 
 
-.. function:: slong fq_nmod_mat_rref(fq_nmod_mat_t A, const fq_nmod_ctx_t ctx)
+.. function:: slong fq_nmod_mat_rref(fq_nmod_mat_t B, const fq_nmod_mat_t A, const fq_nmod_ctx_t ctx)
 
-    Puts `A` in reduced row echelon form and returns the rank of `A`.
+    Puts `B` in reduced row echelon form and returns the rank of `A`.
 
     The rref is computed by first obtaining an unreduced row echelon
     form via LU decomposition and then solving an additional

doc/source/fq_zech_mat.rst

@@ -343,9 +343,9 @@ Reduced row echelon form
 --------------------------------------------------------------------------------
 
 
-.. function:: slong fq_zech_mat_rref(fq_zech_mat_t A, const fq_zech_ctx_t ctx)
+.. function:: slong fq_zech_mat_rref(fq_zech_mat_t B, const fq_zech_mat_t A, const fq_zech_ctx_t ctx)
 
-    Puts `A` in reduced row echelon form and returns the rank of `A`.
+    Puts `B` in reduced row echelon form and returns the rank of `A`.
 
     The rref is computed by first obtaining an unreduced row echelon
     form via LU decomposition and then solving an additional

src/fmpz_mat.h

@@ -276,10 +276,6 @@ slong fmpz_mat_rref_mul(fmpz_mat_t B, fmpz_t den, const fmpz_mat_t A);
 int fmpz_mat_is_in_rref_with_rank(const fmpz_mat_t A, const fmpz_t den,
         slong rank);
 
-/* Modular gaussian elimination *********************************************/
-
-slong fmpz_mat_rref_mod(slong * perm, fmpz_mat_t A, const fmpz_t p);
-
 /* Modular Howell and strong echelon form ***********************************/
 
 slong fmpz_mat_howell_form_mod(fmpz_mat_t A, const fmpz_t mod);

src/fmpz_mat/rref_mod.c

@@ -86,7 +86,6 @@
 #include "t-rank.c"
 #include "t-rref.c"
 #include "t-rref_fflu.c"
-#include "t-rref_mod.c"
 #include "t-rref_mul.c"
 #include "t-scalar_addmul_fmpz.c"
 #include "t-scalar_addmul_nmod_mat_fmpz.c"
@@ -186,7 +185,6 @@ test_struct tests[] =
     TEST_FUNCTION(fmpz_mat_rank),
     TEST_FUNCTION(fmpz_mat_rref),
     TEST_FUNCTION(fmpz_mat_rref_fflu),
-    TEST_FUNCTION(fmpz_mat_rref_mod),
     TEST_FUNCTION(fmpz_mat_rref_mul),
     TEST_FUNCTION(fmpz_mat_scalar_addmul_fmpz),
     TEST_FUNCTION(fmpz_mat_scalar_addmul_nmod_mat_fmpz),