-
Notifications
You must be signed in to change notification settings - Fork 65
docs(fix): Fix angle spec documentation #2953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
|
Hi @daquintero . I fixed the names and lumped another small fix to the |
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
|
Hi @daquinteroflex |
|
Feel free to merge! |
f0a35da to
205cf88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes incorrect class names in the API documentation for plane wave sources by updating them to match the actual classes defined in the codebase.
- Corrected
tidy3d.FixedInPlaneKtotidy3d.FixedInPlaneKSpec - Corrected
tidy3d.FixedAngletotidy3d.FixedAngleSpec
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile Overview
Updated On: 2025-10-31 20:43:41 UTC
Greptile Summary
Fixed incorrect class names in the API documentation for plane wave sources.
tidy3d.FixedInPlaneKtotidy3d.FixedInPlaneKSpectidy3d.FixedAngletotidy3d.FixedAngleSpecThe documentation previously referenced non-existent class names. The actual classes in the codebase are
FixedInPlaneKSpecandFixedAngleSpec, both properly exported intidy3d/__init__.py. This fix ensures the documentation correctly references the actual API, allowing Sphinx to properly generate documentation links.Confidence Score: 5/5
FixedInPlaneKSpecandFixedAngleSpec), which are properly exported and available in the tidy3d namespace. No code logic is affected, only documentation references.Important Files Changed
File Analysis
FixedInPlaneKandFixedAngleto the correctFixedInPlaneKSpecandFixedAngleSpecSequence Diagram
sequenceDiagram participant Dev as Developer participant Docs as Documentation System participant Sphinx as Sphinx Builder participant API as API Reference Dev->>Docs: Update sources.rst with correct class names Note over Dev,Docs: FixedInPlaneK → FixedInPlaneKSpec<br/>FixedAngle → FixedAngleSpec Docs->>Sphinx: Process RST file Sphinx->>API: Generate API documentation API->>Sphinx: Import tidy3d.FixedInPlaneKSpec API->>Sphinx: Import tidy3d.FixedAngleSpec Sphinx-->>Dev: Documentation successfully built