fix(tidy3d): FXC-4026-parsing-error-in-klayout-drc-results-loader

Author: marcorudolphflex

CHANGELOG.md

@@ -67,6 +67,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Improved type hints for `Tidy3dBaseModel`, so that all derived classes will have more accurate return types.
 - More robust method for suppressing RF license warnings during tests.
 - Fixed frequency sampling of `TransmissionLineDataset` within `MicrowaveModeData` when using group index calculation.
+- Fixed DRC parsing for quoted categories in klayout plugin.
 
 ### Removed
 - Removed deprecated `use_complex_fields` parameter from `TwoPhotonAbsorption` and `KerrNonlinearity`. Parameters `beta` and `n2` are now real-valued only, as is `n0` if specified.

tests/test_plugins/klayout/drc/drc_results_widthonly_clean.lyrdb renamed to tests/test_plugins/klayout/drc/drc_results_clean.lyrdb

@@ -13,6 +13,12 @@
    <categories>
    </categories>
   </category>
+  <category>
+   <name>'quoted category'</name>
+   <description>test if quoted categories are parsed correctly</description>
+   <categories>
+   </categories>
+  </category>
  </categories>
  <cells>
   <cell>

tests/test_plugins/klayout/drc/test_drc.py

@@ -326,9 +326,9 @@ def drc_results(self):
         return DRCResults.load(filepath / "drc_results.lyrdb")
 
     @pytest.fixture(scope="class")
-    def drc_results_widthonly_clean(self):
+    def drc_results_clean(self):
         """Load the DRC results"""
-        return DRCResults.load(filepath / "drc_results_widthonly_clean.lyrdb")
+        return DRCResults.load(filepath / "drc_results_clean.lyrdb")
 
     def test_result_file_load(self, tmp_path):
         """Test that result file loading works"""
@@ -347,10 +347,10 @@ def test_result_file_load(self, tmp_path):
         with pytest.raises(ET.ParseError):
             DRCResults.load(tmp_path / "bad_resultsfile.lyrdb")
 
-    def test_is_drc_clean(self, drc_results, drc_results_widthonly_clean):
+    def test_is_drc_clean(self, drc_results, drc_results_clean):
         """Test DRCResults.is_clean"""
         assert not drc_results.is_clean
-        assert drc_results_widthonly_clean.is_clean
+        assert drc_results_clean.is_clean
 
     def test_count_drc_violations(self, drc_results):
         """Test that counting violations works"""

tidy3d/plugins/klayout/drc/results.py

@@ -350,13 +350,22 @@ def violations_from_file(resultsfile: Union[str, Path]) -> dict[str, DRCViolatio
     # Initialize violations dict with all the categories
     violations = {}
     for category in xmltree.getroot().findall(".//categories/category/name"):
-        violations[category.text] = DRCViolation(category=category.text, markers=())
+        category_name = category.text
+        if category_name is None:
+            raise FileError("Encountered DRC category without a name in results file.")
+        category_name = category_name.strip().strip("'\"")
+        violations[category_name] = DRCViolation(category=category_name, markers=())
 
     # Parse markers
     for item in xmltree.getroot().findall(".//item"):
-        category = item.find("category").text
+        category_el = item.find("category")
+        if category_el is None or category_el.text is None:
+            raise FileError("Encountered DRC item without a category in results file.")
+        category = category_el.text.strip().strip("'\"")
         value = item.find("values/value").text
         marker = parse_violation_value(value)
+        if category not in violations:
+            violations[category] = DRCViolation(category=category, markers=())
         violations[category] = DRCViolation(
             category=category,
             markers=(*violations[category].markers, marker),