Skip to content

Commit 6922499

Browse files
fix: specify minimum pre-commit version
1 parent 64ad0f6 commit 6922499

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

.github/workflows/tidy3d-python-client-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ jobs:
239239
lint-commit-messages:
240240
needs: determine-test-scope
241241
runs-on: ubuntu-latest
242-
if: needs.determine-test-scope.outputs.pr_review_tests == 'true'
242+
if: needs.determine-test-scope.outputs.code_quality_tests == 'true'
243243
name: lint-commit-messages
244244
steps:
245245
- name: Check out source code
@@ -624,7 +624,7 @@ jobs:
624624
exit 1
625625
626626
- name: check-commit-message-linting
627-
if: ${{ github.event_name == 'merge_group' && needs.lint-commit-messages.result != 'success' }}
627+
if: ${{ needs.determine-test-scope.outputs.code_quality_tests == 'true' && needs.lint-commit-messages.result != 'success' }}
628628
run: |
629629
echo "❌ Commit message linting failed."
630630
exit 1

.pre-commit-config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
minimum_pre_commit_version: '4.0.0'
12
default_install_hook_types:
23
- pre-commit
34
- commit-msg

poetry.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ dill = { version = "*", optional = true }
5656
ipython = { version = "*", optional = true }
5757
memory_profiler = { version = "*", optional = true }
5858
psutil = { version = "*", optional = true }
59-
pre-commit = { version = "*", optional = true }
59+
pre-commit = { version = ">=4.*", optional = true }
6060
pylint = { version = "*", optional = true }
6161
pytest = { version = ">=8.1", optional = true }
6262
pytest-timeout = { version = "*", optional = true }

0 commit comments

Comments
 (0)