fixes

Author: daquinteroflex

.github/workflows/tidy3d-python-client-release.yml

@@ -9,13 +9,15 @@ on:
         type: string
 
       release_type:
-        description: 'Release Type (draft=test, final=PyPI)'
+        description: 'Release Type (determines deployment targets)'
         type: choice
         default: 'draft'
         required: false
         options:
           - draft
-          - final
+          - codeartifact
+          - testpypi
+          - pypi
 
       workflow_control:
         description: 'Workflow Stage Control'
@@ -69,7 +71,7 @@ on:
         type: string
 
       release_type:
-        description: 'Release Type (draft=test, final=PyPI)'
+        description: 'Release Type (determines deployment targets)'
         type: string
         default: 'draft'
         required: false
@@ -157,9 +159,9 @@ jobs:
           echo "Release tag: $RELEASE_TAG"
           echo "Release type: $RELEASE_TYPE"
           
-          # Only enforce strict validation for final releases
-          if [[ "$RELEASE_TYPE" == "final" ]]; then
-            echo "Final release detected - applying strict tag validation"
+          # Only enforce strict validation for PyPI releases
+          if [[ "$RELEASE_TYPE" == "pypi" ]]; then
+            echo "PyPI release detected - applying strict tag validation"
             
             # Tag must match semantic versioning: v{major}.{minor}.{patch}[rc{num}]
             TAG_REGEX='^v[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$'
@@ -173,7 +175,7 @@ jobs:
             
             echo "Tag format is valid"
           else
-            echo "Draft release - skipping strict tag validation"
+            echo "Non-PyPI release - skipping strict tag validation"
             echo "Tag accepted: $RELEASE_TAG"
           fi
       
@@ -258,19 +260,19 @@ jobs:
           SEMVER_REGEX='^v[0-9]+\.[0-9]+\.[0-9]+$'
           
           # Only push to latest if:
-          # 1. Release type is final
+          # 1. Release type is pypi
           # 2. Not an RC release
           # 3. Tag matches semantic versioning pattern v{major}.{minor}.{patch}
-          if [[ "$RELEASE_TYPE" == "final" && "$is_rc_release" == "false" && "$RELEASE_TAG" =~ $SEMVER_REGEX ]]; then
+          if [[ "$RELEASE_TYPE" == "pypi" && "$is_rc_release" == "false" && "$RELEASE_TAG" =~ $SEMVER_REGEX ]]; then
             push_to_latest=true
             echo "=== Push to Latest ==="
             echo "Will push to 'latest' branch in readthedocs"
-            echo "   Conditions met: final release + non-RC + semantic version tag"
+            echo "   Conditions met: pypi release + non-RC + semantic version tag"
           else
             echo "=== Push to Latest ==="
             echo " Will NOT push to 'latest' branch"
-            if [[ "$RELEASE_TYPE" != "final" ]]; then
-              echo "   Reason: Not a final release (is $RELEASE_TYPE)"
+            if [[ "$RELEASE_TYPE" != "pypi" ]]; then
+              echo "   Reason: Not a PyPI release (is $RELEASE_TYPE)"
             elif [[ "$is_rc_release" == "true" ]]; then
               echo "   Reason: RC release"
             elif [[ ! "$RELEASE_TAG" =~ $SEMVER_REGEX ]]; then
@@ -290,13 +292,13 @@ jobs:
             [[ "$CLIENT_TESTS" == "true" ]] && run_client_tests=true
             [[ "$CLI_TESTS" == "true" ]] && run_cli_tests=true
             
-            # Submodule tests: user input OR auto-enable for final non-RC releases
+            # Submodule tests: user input OR auto-enable for PyPI non-RC releases
             if [[ "$SUBMODULE_TESTS" == "true" ]]; then
               run_submodule_tests=true
               echo "??  Submodule tests enabled by user input"
             elif [[ "$push_to_latest" == "true" ]]; then
               run_submodule_tests=true
-              echo "??  Submodule tests auto-enabled for final non-RC release (push_to_latest=true)"
+              echo "??  Submodule tests auto-enabled for PyPI non-RC release (push_to_latest=true)"
             fi
           fi
           
@@ -334,17 +336,34 @@ jobs:
             else
               # Automatic defaults based on release_type
               echo "Using automatic deployment defaults for release_type: $RELEASE_TYPE"
-              if [[ "$RELEASE_TYPE" == "final" ]]; then
-                # Final releases: deploy to production PyPI
-                deploy_pypi=true
-              elif [[ "$RELEASE_TYPE" == "draft" ]]; then
-                # Draft releases: no deployment by default
-                echo "Draft release - no automatic deployments"
-              fi
+              case "$RELEASE_TYPE" in
+                pypi)
+                  # PyPI releases: deploy to all targets (TestPyPI, PyPI, AWS CodeArtifact)
+                  deploy_testpypi=true
+                  deploy_pypi=true
+                  deploy_aws=true
+                  ;;
+                testpypi)
+                  # TestPyPI releases: deploy to TestPyPI and AWS CodeArtifact
+                  deploy_testpypi=true
+                  deploy_aws=true
+                  ;;
+                codeartifact)
+                  # CodeArtifact only
+                  deploy_aws=true
+                  ;;
+                draft)
+                  # Draft releases: no deployment
+                  echo "Draft release - no automatic deployments"
+                  ;;
+                *)
+                  echo "Unknown release_type: $RELEASE_TYPE - no automatic deployments"
+                  ;;
+              esac
             fi
             
-            # Sync branches on final releases if deploying to PyPI
-            if [[ "$RELEASE_TYPE" == "final" && "$deploy_pypi" == "true" ]]; then
+            # Sync branches on PyPI releases if deploying to PyPI
+            if [[ "$RELEASE_TYPE" == "pypi" && "$deploy_pypi" == "true" ]]; then
               sync_branches=true
             fi
           fi