Skip to content

Commit 01564e9

Browse files
committed
Address review comments.
1 parent a4d1a17 commit 01564e9

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

csrc/trtllm_mnnvl_allreduce.cu

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,7 @@ void trtllm_mnnvl_allreduce_fusion(TensorView input, int64_t multicast_buffer_pt
103103
status = twoshotAllreduceFusionDispatch<c_type>(params);
104104
}
105105
TVM_FFI_ICHECK(status == cudaSuccess)
106-
<< "twoshot_allreduce_dispatch_world_size failed with error code "
107-
<< cudaGetErrorString(status);
106+
<< "trtllm_mnnvl_allreduce_fusion failed with error code " << cudaGetErrorString(status);
108107
});
109108
}
110109

flashinfer/comm/trtllm_mnnvl_ar.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -192,9 +192,6 @@ def trtllm_mnnvl_allreduce_fusion(
192192
gamma: Gamma tensor (if rmsnorm)
193193
epsilon: Epsilon value (if rmsnorm)
194194
"""
195-
print(
196-
f"[Rank {rank}] Inside Kernel: multicast_buffer_ptr: {multicast_buffer_ptr:x}, buffer_ptrs_dev: {buffer_ptrs_dev:x}, buffer_ptr_local: {buffer_ptr_local:x}, buffer_flags_mnnvl: {buffer_flags_mnnvl}"
197-
)
198195
module.trtllm_mnnvl_allreduce_fusion(
199196
input,
200197
multicast_buffer_ptr,

tests/comm/test_trtllm_mnnvl_allreduce.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Check torch version:
2-
from typing import Tuple, Optional
2+
import traceback
3+
from typing import Tuple
34

45
import pytest
56
import torch
@@ -451,8 +452,6 @@ def run_mnnvl_ar_full(
451452
rank_failed = True
452453
failure_message = f"FAILED[rank={rank}]: seq_lens={seq_lens}, fusion={fusion}, dtype={dtype} failed: {e}"
453454
print(failure_message)
454-
import traceback
455-
456455
print(traceback.format_exc())
457456

458457
# Gather failure status from all ranks for logging

0 commit comments

Comments
 (0)