refactor: removed old importers

Author: dieppa

core/flamingock-core-api/src/main/java/io/flamingock/api/annotations/Stage.java

@@ -50,7 +50,5 @@
     String name() default "";
 
     String description() default "";
-    
-    StageType type() default StageType.DEFAULT;
 
 }

core/flamingock-core/src/main/java/io/flamingock/internal/core/task/navigation/navigator/ChangeProcessStrategyFactory.java

@@ -108,7 +108,7 @@ public ChangeProcessStrategy build() {
 
         changeLogger.logStartChangeProcessStrategy(change.getId());
 
-        TargetSystemOps targetSystemOps = getTargetSystem(change.getId());
+        TargetSystemOps targetSystemOps = getTargetSystem();
 
         // Log target system resolution
         changeLogger.logTargetSystemResolved(change.getId(), change.getTargetSystem());
@@ -130,11 +130,11 @@ public ChangeProcessStrategy build() {
         );
     }
 
-    private TargetSystemOps getTargetSystem(String changeId) {
+    private TargetSystemOps getTargetSystem() {
         try {
             return targetSystemManager.getTargetSystem(change.getTargetSystem());
         } catch (Exception e) {
-            String message = String.format("Error in change [%s] : %s", changeId, e.getMessage());
+            String message = String.format("Error in change [%s] : %s", change.getId(), e.getMessage());
             throw new FlamingockException(message);
         }
     }

core/flamingock-processor/src/main/java/io/flamingock/core/processor/FlamingockAnnotationProcessor.java

@@ -315,36 +315,6 @@ private int getStageTypePriority(StageType stageType) {
         }
     }
 
-    /**
-     * Validates that stage types conform to the restrictions:
-     * - Maximum 1 SYSTEM stage allowed
-     * - Maximum 1 LEGACY stage allowed
-     * - Unlimited DEFAULT stages allowed
-     *
-     * @param stages the stages to validate
-     * @throws RuntimeException if validation fails
-     */
-    private void validateStageTypes(Stage[] stages) {
-        int systemStageCount = 0;
-        int legacyStageCount = 0;
-
-        for (Stage stage : stages) {
-            StageType stageType = stage.type();
-
-            if (stageType == StageType.SYSTEM) {
-                systemStageCount++;
-                if (systemStageCount > 1) {
-                    throw new RuntimeException("Multiple SYSTEM stages are not allowed. Only one stage with type StageType.SYSTEM is permitted.");
-                }
-            } else if (stageType == StageType.LEGACY) {
-                legacyStageCount++;
-                if (legacyStageCount > 1) {
-                    throw new RuntimeException("Multiple LEGACY stages are not allowed. Only one stage with type StageType.LEGACY is permitted.");
-                }
-            }
-        }
-    }
-
     /**
      * Validates that stage types from YAML conform to the restrictions:
      * - Maximum 1 SYSTEM stage allowed
@@ -450,7 +420,7 @@ private PreviewStage mapAnnotationToStage(Map<String, List<CodePreviewChange>> c
             logger.verbose("Resources directory: " + resourcesDir);
         }
 
-        return PreviewStage.defaultBuilder(stageAnnotation.type())
+        return PreviewStage.defaultBuilder(StageType.DEFAULT)
                 .setName(name)
                 .setDescription(stageAnnotation.description().isEmpty() ? null : stageAnnotation.description())
                 .setSourcesRoots(sourceRoots)
@@ -704,10 +674,6 @@ private void validateConfiguration(EnableFlamingock pipelineAnnotation, boolean
             throw new RuntimeException("@EnableFlamingock annotation must specify either configFile OR stages configuration.");
         }
 
-        // Validate stage type restrictions when using annotation-based configuration
-        if (hasStagesInAnnotation) {
-            validateStageTypes(pipelineAnnotation.stages());
-        }
     }
 
     /**

core/flamingock-processor/src/test/java/io/flamingock/core/processor/PipelinePreProcessorTest.java

@@ -178,68 +178,6 @@ void shouldCreatePipelineWithCorrectObjectStructure() throws Exception {
         assertEquals(StageType.DEFAULT, firstStage.getType());
     }
 
-    /**
-     * Test validation that only one SYSTEM stage is allowed in annotation configuration.
-     */
-    @Test
-    @DisplayName("Should throw error for multiple SYSTEM stages in annotation configuration")
-    void shouldThrowErrorForMultipleSystemStagesInAnnotation() throws Exception {
-        // Given - create annotation with multiple system stages
-        EnableFlamingock annotation = new MockFlamingockBuilder()
-            .withStages(
-                createMockStage("", StageType.SYSTEM, "com.example.system1"),
-                createMockStage("", StageType.SYSTEM, "com.example.system2"),
-                createMockStage("", StageType.DEFAULT, "com.example.migrations")
-            )
-            .build();
-        Map<String, List<AbstractPreviewTask>> changes = createMockChangesMap();
-        FlamingockAnnotationProcessor processor = new FlamingockAnnotationProcessor();
-        
-        // When & Then - should throw RuntimeException
-        Exception exception = assertThrows(Exception.class, () -> 
-            callGetPipelineFromProcessChanges(processor, changes, annotation));
-        
-        Throwable cause = exception.getCause();
-        if (cause instanceof RuntimeException) {
-            assertTrue(cause.getMessage().contains("Multiple SYSTEM stages are not allowed"),
-                    "Should have error about multiple SYSTEM stages");
-        } else {
-            assertTrue(exception.getMessage().contains("Multiple SYSTEM stages are not allowed"),
-                    "Should have error about multiple SYSTEM stages");
-        }
-    }
-
-    /**
-     * Test validation that only one LEGACY stage is allowed in annotation configuration.
-     */
-    @Test
-    @DisplayName("Should throw error for multiple LEGACY stages in annotation configuration")
-    void shouldThrowErrorForMultipleLegacyStagesInAnnotation() throws Exception {
-        // Given - create annotation with multiple legacy stages
-        EnableFlamingock annotation = new MockFlamingockBuilder()
-            .withStages(
-                createMockStage("", StageType.LEGACY, "com.example.legacy1"),
-                createMockStage("", StageType.LEGACY, "com.example.legacy2"),
-                createMockStage("", StageType.DEFAULT, "com.example.migrations")
-            )
-            .build();
-        Map<String, List<AbstractPreviewTask>> changes = createMockChangesMap();
-        FlamingockAnnotationProcessor processor = new FlamingockAnnotationProcessor();
-        
-        // When & Then - should throw RuntimeException
-        Exception exception = assertThrows(Exception.class, () -> 
-            callGetPipelineFromProcessChanges(processor, changes, annotation));
-        
-        Throwable cause = exception.getCause();
-        if (cause instanceof RuntimeException) {
-            assertTrue(cause.getMessage().contains("Multiple LEGACY stages are not allowed"),
-                    "Should have error about multiple LEGACY stages");
-        } else {
-            assertTrue(exception.getMessage().contains("Multiple LEGACY stages are not allowed"),
-                    "Should have error about multiple LEGACY stages");
-        }
-    }
-
     /**
      * Test validation that multiple DEFAULT stages are allowed.
      */
@@ -249,9 +187,9 @@ void shouldAllowMultipleDefaultStagesInAnnotation() throws Exception {
         // Given - create annotation with multiple default stages
         EnableFlamingock annotation = new MockFlamingockBuilder()
             .withStages(
-                createMockStage("", StageType.DEFAULT, "com.example.migrations1"),
-                createMockStage("", StageType.DEFAULT, "com.example.migrations2"),
-                createMockStage("", StageType.DEFAULT, "com.example.migrations3")
+                createMockStage("", "com.example.migrations1"),
+                createMockStage("", "com.example.migrations2"),
+                createMockStage("", "com.example.migrations3")
             )
             .build();
         Map<String, List<AbstractPreviewTask>> changes = createMockChangesMap();
@@ -266,47 +204,6 @@ void shouldAllowMultipleDefaultStagesInAnnotation() throws Exception {
         assertNull(pipeline.getSystemStage(), "Should not have system stage");
     }
 
-    /**
-     * Test that stages are ordered correctly regardless of declaration order.
-     */
-    @Test
-    @DisplayName("Should order stages by type priority: LEGACY before DEFAULT")
-    void shouldOrderStagesByTypePriorityLegacyBeforeDefault() throws Exception {
-        // Given - create annotation with stages in reverse order (DEFAULT first, LEGACY second)
-        EnableFlamingock annotation = new MockFlamingockBuilder()
-            .withStages(
-                createMockStage("", StageType.DEFAULT, "com.example.migrations"),
-                createMockStage("", StageType.LEGACY, "com.example.init"),
-                createMockStage("", StageType.DEFAULT, "com.example.cleanup")
-            )
-            .build();
-        Map<String, List<AbstractPreviewTask>> changes = createMockChangesMap();
-        FlamingockAnnotationProcessor processor = new FlamingockAnnotationProcessor();
-        
-        // When - build pipeline from annotation
-        PreviewPipeline pipeline = buildPipelineFromAnnotation(processor, annotation, changes);
-        
-        // Then - verify stages are sorted by type priority
-        assertNotNull(pipeline, "Pipeline should be created");
-        assertEquals(3, pipeline.getStages().size(), "Should have 3 stages");
-        
-        PreviewStage[] stages = pipeline.getStages().toArray(new PreviewStage[0]);
-        
-        // First stage should be LEGACY (highest priority)
-        assertEquals(StageType.LEGACY, stages[0].getType());
-        assertEquals("init", stages[0].getName());
-        assertEquals("com.example.init", stages[0].getSourcesPackage());
-        
-        // Second and third stages should be DEFAULT (lower priority)
-        assertEquals(StageType.DEFAULT, stages[1].getType());
-        assertEquals("migrations", stages[1].getName());
-        assertEquals("com.example.migrations", stages[1].getSourcesPackage());
-        
-        assertEquals(StageType.DEFAULT, stages[2].getType());
-        assertEquals("cleanup", stages[2].getName());
-        assertEquals("com.example.cleanup", stages[2].getSourcesPackage());
-    }
-
     /**
      * Test that YAML stages are ordered correctly regardless of declaration order.
      */
@@ -573,7 +470,7 @@ private Map<String, List<AbstractPreviewTask>> createMockChangesMap() {
     private EnableFlamingock createMockAnnotationWithStages() {
         return new MockFlamingockBuilder()
             .withStages(
-                createMockStage("", StageType.DEFAULT, "com.example.migrations")
+                createMockStage("", "com.example.migrations")
             )
             .build();
     }
@@ -588,11 +485,10 @@ private EnableFlamingock createMockAnnotationWithNeitherFileNorStages() {
         return new MockFlamingockBuilder().build();
     }
 
-    private Stage createMockStage(String name, StageType type, String location) {
+    private Stage createMockStage(String name, String location) {
         return new Stage() {
             @Override public String name() { return name; }
             @Override public String description() { return ""; }
-            @Override public StageType type() { return type; }
             @Override public String location() { return location; }
             @Override public Class<? extends java.lang.annotation.Annotation> annotationType() { return Stage.class; }
         };