Dynamic height in NestedRow component (#187)

* Dynamic height if necessary

* Updated tests

* Prettier config

Author: fjmorant

.circleci/config.yml

@@ -9,4 +9,4 @@ jobs:
       - run: yarn install
       - run: yarn tslint
       - run: yarn type-check
-      - run: yarn test
+      - run: yarn test-coverage

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+    "prettier.configPath": "prettier.config.js"
+}

package.json

@@ -5,7 +5,8 @@
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "scripts": {
-    "test": "jest  && codecov",
+    "test": "jest",
+    "test-coverage": "jest && codecov",
     "tslint": "tslint -p .",
     "type-check": "tsc --noEmit",
     "prepublishOnly": "tsc -p ./ --outDir dist/",

prettier.config.js

@@ -1,6 +1,6 @@
 module.exports = {
     trailingComma: 'es5',
-    tabWidth: 2,
+    tabWidth: 4,
     semi: false,
     singleQuote: true,
     bracketSpacing: false,

src/NestedRow.tsx

@@ -21,7 +21,7 @@ export interface IProps {
 
 const NestedRow = React.memo(
     ({
-        height = 50,
+        height,
         children,
         level = 0,
         paddingLeftIncrement = 10,
@@ -32,9 +32,9 @@ const NestedRow = React.memo(
                 styles.nestedRow,
                 {
                     ...style,
-                    height,
                     paddingLeft: level * paddingLeftIncrement,
                 },
+                height ? {height} : {},
             ]}
         >
             {children}

src/__snapshots__/NestedListView.test.tsx.snap

@@ -168,9 +168,9 @@ exports[`NestedListView renders with NestedRow 1`] = `
                 "justifyContent": "center",
               },
               Object {
-                "height": 50,
                 "paddingLeft": 10,
               },
+              Object {},
             ]
           }
         />
@@ -199,9 +199,9 @@ exports[`NestedListView renders with NestedRow 1`] = `
                 "justifyContent": "center",
               },
               Object {
-                "height": 50,
                 "paddingLeft": 10,
               },
+              Object {},
             ]
           }
         />
@@ -230,9 +230,9 @@ exports[`NestedListView renders with NestedRow 1`] = `
                 "justifyContent": "center",
               },
               Object {
-                "height": 50,
                 "paddingLeft": 10,
               },
+              Object {},
             ]
           }
         />

src/__snapshots__/NestedRow.test.tsx.snap

@@ -11,9 +11,11 @@ exports[`NestedListView renders customised 1`] = `
       Object {
         "borderColor": "black",
         "borderWidth": 1,
-        "height": 60,
         "paddingLeft": 15,
       },
+      Object {
+        "height": 60,
+      },
     ]
   }
 >
@@ -34,9 +36,9 @@ exports[`NestedListView renders with simple array 1`] = `
       Object {
         "borderColor": "black",
         "borderWidth": 1,
-        "height": 50,
         "paddingLeft": 10,
       },
+      Object {},
     ]
   }
 >
@@ -57,9 +59,9 @@ exports[`NestedListView renders with simple array without level 1`] = `
       Object {
         "borderColor": "black",
         "borderWidth": 1,
-        "height": 50,
         "paddingLeft": 0,
       },
+      Object {},
     ]
   }
 >