Skip to content

Commit 60b86ba

Browse files
committed
Merge branch 'GenoD-master'
2 parents 62b7d1a + aac75d7 commit 60b86ba

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

modules/__tests__/animate-scroll-test.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,9 @@ describe('AnimateScroll', () => {
117117

118118
it('scrolls to bottom', (done) => {
119119
render(tallComponent, node, () => {
120-
animateScroll.scrollToBottom({ duration: duration });
121-
120+
animateScroll.scrollToBottom({ duration: duration });
122121
setTimeout(() => {
123-
var offset = 16;
124-
expect(window.scrollY || window.pageYOffset).toEqual(node.offsetHeight - window.innerHeight + offset);
122+
expect(window.scrollY || window.pageYOffset).toEqual(document.documentElement.scrollTop);
125123
done();
126124
}, waitDuration);
127125
});

modules/mixins/animate-scroll.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,17 @@ const animateTopScroll = (y, options, to, target) => {
163163

164164
if (options && options.delay > 0) {
165165
options.data.delayTimeout = window.setTimeout(() => {
166+
if (events.registered['begin']) {
167+
events.registered['begin'](options.data.to, options.data.target);
168+
}
166169
requestAnimationFrameHelper.call(window, easedAnimate);
167170
}, options.delay);
168171
return;
169172
}
170173

174+
if (events.registered['begin']) {
175+
events.registered['begin'](options.data.to, options.data.target);
176+
}
171177
requestAnimationFrameHelper.call(window, easedAnimate);
172178

173179
};

modules/mixins/scroller.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import utils from './utils';
22
import animateScroll from './animate-scroll';
3-
import events from'./scroll-events';
3+
import events from './scroll-events';
44

55
let __mapped = {}
66
let __activeLink;
@@ -48,10 +48,6 @@ export default {
4848
containerElement = document;
4949
}
5050

51-
if(events.registered.begin) {
52-
events.registered.begin(to, target);
53-
}
54-
5551
props.absolute = true;
5652

5753
let scrollOffset = utils.scrollOffset(containerElement, target) + (props.offset || 0);
@@ -60,6 +56,10 @@ export default {
6056
* if animate is not provided just scroll into the view
6157
*/
6258
if(!props.smooth) {
59+
if(events.registered['begin']) {
60+
events.registered['begin'](to, target);
61+
}
62+
6363
if (containerElement === document) {
6464
window.scrollTo(0, scrollOffset);
6565
} else {

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)