Skip to content

Fix Buffer Overflow Vulnerabilities in Firmata SYSEX Message Processing #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Buffer Overflow Vulnerabilities in Firmata SYSEX Message Processing #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions FirmataParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,8 @@ void FirmataParser::processSysexMessage(void)
if ( 3 > sysexBytesRead ) {
(*currentReportFirmwareCallback)(currentReportFirmwareCallbackContext, 0, 0, (const char *)NULL);
} else {
const size_t end_of_string = (string_offset + decodeByteStream((sysexBytesRead - string_offset), &dataBuffer[string_offset]));
const size_t bytec = min(sysexBytesRead - string_offset, dataBufferSize - string_offset);
const size_t end_of_string = (string_offset + decodeByteStream(bytec, &dataBuffer[string_offset]));
bufferDataAtPosition('\0', end_of_string); // NULL terminate the string
(*currentReportFirmwareCallback)(currentReportFirmwareCallbackContext, (size_t)dataBuffer[major_version_offset], (size_t)dataBuffer[minor_version_offset], (const char *)&dataBuffer[string_offset]);
}
Expand All @@ -445,7 +446,8 @@ void FirmataParser::processSysexMessage(void)
case STRING_DATA:
if (currentStringCallback) {
const size_t string_offset = 1;
const size_t end_of_string = (string_offset + decodeByteStream((sysexBytesRead - string_offset), &dataBuffer[string_offset]));
const size_t bytec = min(sysexBytesRead - string_offset, dataBufferSize - string_offset);
const size_t end_of_string = (string_offset + decodeByteStream(bytec, &dataBuffer[string_offset]));
bufferDataAtPosition('\0', end_of_string); // NULL terminate the string
(*currentStringCallback)(currentStringCallbackContext, (const char *)&dataBuffer[string_offset]);
}
Expand Down