Fix Buffer Overflow Vulnerabilities in Firmata SYSEX Message Processing #522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
When processing oversized SYSEX messages, buffer overflow occurs due to missing bounds checks in
processSysexMessage()anddecodeByteStream(). For example, whensysexBytesRead = 148butdataBufferSize = 64, the system attempts to process 147 bytes of data in a 64-byte buffer(https://github.com/firmata/arduino/blob/main/FirmataParser.cpp#L448). This causes memory corruption by:dataBufferboundaries indecodeByteStream()dataBufferpointer itself through out-of-bounds writesdataBufferpointer is dereferencedProposed Fix
Ensure
decodeByteStream()only processes data that actually exists withindataBufferbounds by usingmin(sysexBytesRead - offset, dataBufferSize - offset)inprocessSysexMessagefunction.