Skip to content

Fix Uninitialized NULL Pointer Dereference Bug in Firmata I2C Message Processing #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Uninitialized NULL Pointer Dereference Bug in Firmata I2C Message Processing #521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions examples/StandardFirmata/StandardFirmata.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,10 @@ void sysexCallback(byte command, byte argc, byte *argv)

switch (command) {
case I2C_REQUEST:
if (argc < 2) {
Firmata.sendString("I2C request requires address and configuration");
return;
}
mode = argv[1] & I2C_READ_WRITE_MODE_MASK;
if (argv[1] & I2C_10BIT_ADDRESS_MODE_MASK) {
Firmata.sendString("10-bit addressing not supported");
Expand All @@ -508,6 +512,10 @@ void sysexCallback(byte command, byte argc, byte *argv)

switch (mode) {
case I2C_WRITE:
if (argc <= 2) {
Firmata.sendString("I2C write requires data payload");
return;
}
Wire.beginTransmission(slaveAddress);
for (byte i = 2; i < argc; i += 2) {
data = argv[i] + (argv[i + 1] << 7);
Expand Down