Fix Uninitialized NULL Pointer Dereference Bug in Firmata I2C Message Processing #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
When I2C SYSEX messages containing the 'v' command byte but without parameters will cause system crashes due to uninitialized NULL pointer dereference in the I2C interrupt handler. When
argc = 0, the code performs out-of-bounds access to determine operation mode, enters I2C write branch(https://github.com/firmata/arduino/blob/main/examples/StandardFirmata/StandardFirmata.ino#L510) without buffer allocation, and crashes when the interrupt handler attempts to write through uninitializedtxBuffer.Proposed Fix
Add comprehensive parameter validation in
sysexCallbackfunction:argc >= 2before I2C request processingargc > 2for I2C write operationswireWriteis called to allocate buffers before transmission