Skip to content

Commit f6b5d24

Browse files
committed
feat: use more informative bk labels
Replace emoji driven labels in favour of simpler labels with more information in them. These labels will be used as names for saved BK results, so instead of simple UUID like "019a53c5-629b-40b1-86f0-a6d45e07aaf9" it will look like "m6g.metal-al2023-linux_6.1-virtio-block-sync". Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
1 parent 5e38aae commit f6b5d24

File tree

2 files changed

+13
-19
lines changed

2 files changed

+13
-19
lines changed

.buildkite/common.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,6 @@ def group(label, command, instances, platforms, **kwargs):
7676
7777
https://buildkite.com/docs/pipelines/group-step
7878
"""
79-
# Use the 1st character of the group name (should be an emoji)
80-
label1 = label[0]
81-
# if the emoji is in the form ":emoji:", pick the entire slug
82-
if label.startswith(":") and ":" in label[1:]:
83-
label1 = label[: label.index(":", 1) + 1]
84-
8579
steps = []
8680
commands = command
8781
if isinstance(command, str):
@@ -92,7 +86,7 @@ def group(label, command, instances, platforms, **kwargs):
9286
args = {"instance": instance, "os": os_, "kv": kv}
9387
step = {
9488
"command": [cmd.format(**args) for cmd in commands],
95-
"label": f"{label1} {instance} {os_} {kv}",
89+
"label": f"{label}-{instance}-{os_}-{kv}",
9690
"agents": args,
9791
}
9892
step_kwargs = dict_fmt(kwargs, args)

.buildkite/pipeline_perf.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,61 +17,61 @@
1717
# has to be the node associated with the NUMA node from which we picked CPUs.
1818
perf_test = {
1919
"virtio-block-sync": {
20-
"label": "💿 Virtio Sync Block Performance",
20+
"label": "virtio-block-sync",
2121
"tests": "integration_tests/performance/test_block.py::test_block_performance -k 'not Async'",
2222
"devtool_opts": "-c 1-10 -m 0",
2323
},
2424
"virtio-block-async": {
25-
"label": "💿 Virtio Async Block Performance",
25+
"label": "virtio-block-async",
2626
"tests": "integration_tests/performance/test_block.py::test_block_performance -k Async",
2727
"devtool_opts": "-c 1-10 -m 0",
2828
},
2929
"vhost-user-block": {
30-
"label": "💿 vhost-user Block Performance",
30+
"label": "vhost-user-block",
3131
"tests": "integration_tests/performance/test_block.py::test_block_vhost_user_performance",
3232
"devtool_opts": "-c 1-10 -m 0",
3333
"ab_opts": "--noise-threshold 0.1",
3434
},
3535
"network": {
36-
"label": "📠 Network Latency and Throughput",
36+
"label": "network",
3737
"tests": "integration_tests/performance/test_network.py",
3838
"devtool_opts": "-c 1-10 -m 0",
3939
# Triggers if delta is > 0.01ms (10µs) or default relative threshold (5%)
4040
# only relevant for latency test, throughput test will always be magnitudes above this anyway
4141
"ab_opts": "--absolute-strength 0.010",
4242
},
4343
"snapshot-latency": {
44-
"label": "📸 Snapshot Latency",
44+
"label": "snapshot-latency",
4545
"tests": "integration_tests/performance/test_snapshot.py::test_restore_latency integration_tests/performance/test_snapshot.py::test_post_restore_latency integration_tests/performance/test_snapshot.py::test_snapshot_create_latency",
4646
"devtool_opts": "-c 1-12 -m 0",
4747
},
4848
"population-latency": {
49-
"label": "📸 Memory Population Latency",
49+
"label": "population-latency",
5050
"tests": "integration_tests/performance/test_snapshot.py::test_population_latency",
5151
"devtool_opts": "-c 1-12 -m 0",
5252
},
5353
"vsock-throughput": {
54-
"label": "🧦 Vsock Throughput",
54+
"label": "vsock-throughput",
5555
"tests": "integration_tests/performance/test_vsock.py",
5656
"devtool_opts": "-c 1-10 -m 0",
5757
},
58-
"memory-overhead": {
59-
"label": "💾 Memory Overhead and 👢 Boottime",
58+
"memory-overhead-and-boottime": {
59+
"label": "memory-overhead-and-boottime",
6060
"tests": "integration_tests/performance/test_memory_overhead.py integration_tests/performance/test_boottime.py::test_boottime",
6161
"devtool_opts": "-c 1-10 -m 0",
6262
},
6363
"jailer": {
64-
"label": "⛓️ jailer",
64+
"label": "jailer",
6565
"tests": "integration_tests/performance/test_jailer.py",
6666
"devtool_opts": "-c 1-10 -m 0",
6767
},
6868
"pmem": {
69-
"label": "💿 Pmem Performance",
69+
"label": "pmem",
7070
"tests": "integration_tests/performance/test_pmem.py",
7171
"devtool_opts": "-c 1-10 -m 0",
7272
},
7373
"mmds": {
74-
"label": ":information_source: MMDS",
74+
"label": "mmds",
7575
"tests": "integration_tests/performance/test_mmds.py",
7676
"devtool_opts": "-c 1-10 -m 0",
7777
},

0 commit comments

Comments
 (0)