Skip to content

Commit 90f2fbf

Browse files
roypatShadowCurse
authored andcommitted
doc: Clarify PR merge requirements
PRs can only get merged if it has at least 2 approvals from maintainers, not 1 approval from a maintainer and 1 approval from someone else (which doesn't make sense). Additionally, all review comments need to be addressed. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
1 parent 51cc5a4 commit 90f2fbf

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ you want to merge your changes to Firecracker:
3232
against the main branch of the Firecracker repository.
3333
1. Add two reviewers to your pull request (a maintainer will do that for you if
3434
you're new). Work with your reviewers to address any comments and obtain a
35-
minimum of 2 approvals, at least one of which must be provided by
36-
[a maintainer](MAINTAINERS.md). To update your pull request amend existing
37-
commits whenever applicable and then push the new changes to your pull
38-
request branch.
35+
minimum of 2 approvals from [maintainers](MAINTAINERS.md). To update your
36+
pull request, amend existing commits whenever applicable. Then force-push the
37+
new changes to your pull request branch. Address all review comments you
38+
receive.
3939
1. Once the pull request is approved, one of the maintainers will merge it.
4040

4141
## Request for Comments

0 commit comments

Comments
 (0)