File tree Expand file tree Collapse file tree 1 file changed +18
-0
lines changed Expand file tree Collapse file tree 1 file changed +18
-0
lines changed Original file line number Diff line number Diff line change @@ -450,6 +450,9 @@ func TestStartVMM(t *testing.T) {
450450}
451451
452452func TestLogAndMetrics (t * testing.T ) {
453+ if skipLogAndMetricsTest () {
454+ t .Skip ()
455+ }
453456 fctesting .RequiresKVM (t )
454457
455458 tests := []struct {
@@ -480,6 +483,21 @@ func TestLogAndMetrics(t *testing.T) {
480483 }
481484}
482485
486+ func skipLogAndMetricsTest () bool {
487+ // Firecracker logging behavior has changed after
488+ // https://github.com/firecracker-microvm/firecracker/pull/4047
489+ // This includes default log level being changed from WARN to INFO
490+ // TODO: Update this test once firecracker version is upgraded to >v1.5.0
491+ version , err := getFirecrackerVersion ()
492+ if err != nil {
493+ return true
494+ }
495+ // match version 1.4.x
496+ pattern := `^1\.4\.\d+$`
497+ match , _ := regexp .MatchString (pattern , version )
498+ return ! match
499+ }
500+
483501func testLogAndMetrics (t * testing.T , logLevel string ) string {
484502 const vmID = "UserSuppliedVMID"
485503
You can’t perform that action at this time.
0 commit comments