Skip to content

Commit fcd4e44

Browse files
committed
update Firestore and fix build errors
1 parent b114e8c commit fcd4e44

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

firestore/app/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ dependencies {
4242
implementation("androidx.multidex:multidex:2.0.1")
4343

4444
// Import the BoM for the Firebase platform
45-
implementation(platform("com.google.firebase:firebase-bom:34.4.0"))
45+
implementation(platform("com.google.firebase:firebase-bom:34.5.0"))
4646

4747
// Declare the dependency for the Cloud Firestore library
4848
// When using the BoM, you don't specify versions in Firebase library dependencies

firestore/app/src/main/java/com/google/example/firestore/DocSnippets.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import com.google.firebase.firestore.EventListener;
2525
import com.google.firebase.firestore.FieldPath;
2626
import com.google.firebase.firestore.FieldValue;
27+
import com.google.firebase.firestore.Filter;
2728
import com.google.firebase.firestore.FirebaseFirestore;
2829
import com.google.firebase.firestore.FirebaseFirestoreException;
2930
import com.google.firebase.firestore.FirebaseFirestoreSettings;
@@ -1434,7 +1435,7 @@ public void orQueryDisjunctions() {
14341435
// [START 20_disjunctions]
14351436
collection.where(Filter.or(
14361437
Filter.inArray("a", Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)),
1437-
Filter.inArray("b", Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)),
1438+
Filter.inArray("b", Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10))
14381439
));
14391440
// [END 20_disjunctions]
14401441

@@ -1450,10 +1451,11 @@ public void orQueryDisjunctions() {
14501451
}
14511452

14521453
public void illegalDisjunctions() {
1454+
CollectionReference collection = db.collection("cities");
14531455
// [START 50_disjunctions]
14541456
collection.where(Filter.and(
14551457
Filter.inArray("a", Arrays.asList(1, 2, 3, 4, 5)),
1456-
Filter.inArray("b", Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)),
1458+
Filter.inArray("b", Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10))
14571459
));
14581460
// [END 50_disjunctions]
14591461
}

firestore/app/src/main/java/com/google/example/firestore/kotlin/DocSnippets.kt

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import com.google.firebase.firestore.AggregateField
88
import com.google.firebase.firestore.AggregateSource
99
import com.google.firebase.firestore.DocumentChange
1010
import com.google.firebase.firestore.FieldValue
11+
import com.google.firebase.firestore.Filter
1112
import com.google.firebase.firestore.FirebaseFirestore
1213
import com.google.firebase.firestore.FirebaseFirestoreException
1314
import com.google.firebase.firestore.MetadataChanges
@@ -1205,14 +1206,14 @@ abstract class DocSnippets(val db: FirebaseFirestore) {
12051206

12061207
// [START 20_disjunctions]
12071208
collection.where(Filter.or(
1208-
Filter.inArray("a", [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]),
1209-
Filter.inArray("b", [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]),
1209+
Filter.inArray("a", listOf(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)),
1210+
Filter.inArray("b", listOf(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)),
12101211
))
12111212
// [END 20_disjunctions]
12121213

12131214
// [START 10_disjunctions]
12141215
collection.where(Filter.and(
1215-
Filter.inArray("a", [1, 2, 3, 4, 5]),
1216+
Filter.inArray("a", listOf(1, 2, 3, 4, 5)),
12161217
Filter.or(
12171218
Filter.equalTo("b", 2),
12181219
Filter.equalTo("c", 3)
@@ -1225,8 +1226,8 @@ abstract class DocSnippets(val db: FirebaseFirestore) {
12251226
val collection = db.collection("cities")
12261227
// [START 50_disjunctions]
12271228
collection.where(Filter.and(
1228-
Filter.inArray("a", [1, 2, 3, 4, 5]),
1229-
Filter.inArray("b", [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]),
1229+
Filter.inArray("a", listOf(1, 2, 3, 4, 5)),
1230+
Filter.inArray("b", listOf(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)),
12301231
));
12311232
// [END 50_disjunctions]
12321233
}

0 commit comments

Comments
 (0)