feat(firebase_database): ServerValue.increment() now correctly accepts a num to support both integers and doubles. (#9101)

Author: russellwheatley

packages/firebase_database/firebase_database/example/pubspec.yaml

@@ -22,6 +22,8 @@ dependency_overrides:
     path: ../../../firebase_core/firebase_core_web
   firebase_database:
     path: ../
+  firebase_database_platform_interface:
+    path: ../../firebase_database_platform_interface
   firebase_database_web:
     path: ../../firebase_database_web
 

packages/firebase_database/firebase_database_platform_interface/lib/src/server_value.dart

@@ -9,7 +9,7 @@ class ServerValue {
 
   /// Returns a placeholder value that can be used to atomically increment the
   /// current database value by the provided delta.
-  static Map<dynamic, dynamic> increment(int delta) {
+  static Map<dynamic, dynamic> increment(num delta) {
     return <dynamic, dynamic>{
       '.sv': {'increment': delta}
     };

tests/test_driver/firebase_database/database_reference_e2e.dart

@@ -147,6 +147,21 @@ void setupDatabaseReferenceTests() {
         expect(value, isNotNull);
         expect(value['list'], data);
       });
+
+      test('Server.increment', () async {
+        final FirebaseDatabase database = FirebaseDatabase.instance;
+        final DatabaseReference ref = database.ref('tests/server-increment');
+        await ref.set(ServerValue.increment(1.5));
+
+        final snap = await ref.get();
+        var value = snap.value;
+        expect(value, 1.5);
+
+        await ref.set(ServerValue.increment(1));
+        final snap2 = await ref.get();
+        var value2 = snap2.value;
+        expect(value2, 2.5);
+      });
     });
   });
 }