fix(firestore, web): fix apply method for arrayRemove & arrayUnion (#9281)

Author: russellwheatley

packages/cloud_firestore/cloud_firestore_web/lib/src/interop/firestore.dart

@@ -707,7 +707,7 @@ class _FieldValueArrayUnion extends _FieldValueArray {
   firestore_interop.FieldValue? _jsify() {
     // This uses var arg so cannot use js package
     return callMethod(
-        firestore_interop.arrayUnion, 'apply', jsify([null, elements]));
+        firestore_interop.arrayUnion, 'apply', [null, jsify(elements)]);
   }
 
   @override
@@ -721,7 +721,7 @@ class _FieldValueArrayRemove extends _FieldValueArray {
   firestore_interop.FieldValue? _jsify() {
     // This uses var arg so cannot use js package
     return callMethod(
-        firestore_interop.arrayRemove, 'apply', jsify([null, elements]));
+        firestore_interop.arrayRemove, 'apply', [null, jsify(elements)]);
   }
 
   @override

packages/cloud_firestore/cloud_firestore_web/lib/src/interop/firestore_interop.dart

@@ -28,12 +28,6 @@ external PromiseJsImpl<DocumentReferenceJsImpl> addDoc(
   dynamic data,
 );
 
-@JS()
-external FieldValue arrayRemove(dynamic elements);
-
-@JS()
-external FieldValue arrayUnion(dynamic elements);
-
 @JS()
 external PromiseJsImpl<void> clearIndexedDbPersistence(
   FirestoreJsImpl firestore,
@@ -637,7 +631,7 @@ abstract class SnapshotOptions {
   external factory SnapshotOptions({String? serverTimestamps});
 }
 
-// We type those 4 functions as Object to avoid an issue with dart2js compilation
+// We type these 6 functions as Object to avoid an issue with dart2js compilation
 // in release mode
 // Discussed internally with dart2js team
 @JS()
@@ -651,3 +645,9 @@ external Object get endBefore;
 
 @JS()
 external Object get endAt;
+
+@JS()
+external Object get arrayRemove;
+
+@JS()
+external Object get arrayUnion;