Skip to content

Commit 99f8b53

Browse files
dackers86dackers86
committed
fix(*): removed redundant useEffects
1 parent 382bb09 commit 99f8b53

File tree

8 files changed

+8
-71
lines changed

8 files changed

+8
-71
lines changed

‎examples/nextjs/.firebaserc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"projects": {
3-
"default": "fir-ui-2025"
3+
"default": "fir-ui-rework"
44
}
55
}

‎examples/nextjs/app/forgot-password/page.tsx‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,9 @@
1515
*/
1616

1717
"use client";
18-
import { useUser } from "@/lib/firebase/hooks";
19-
import { redirect } from "next/navigation";
20-
import ForgotPasswordScreen from "./screen";
21-
22-
export default async function ForgotPasswordPage() {
23-
const user = await useUser();
2418

25-
if (user) {
26-
return redirect("/");
27-
}
19+
import ForgotPasswordScreen from "./screen";
2820

21+
export default function ForgotPasswordPage() {
2922
return <ForgotPasswordScreen />;
3023
}

‎examples/nextjs/app/layout.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import type { Metadata } from "next";
1919
import { Geist, Geist_Mono } from "next/font/google";
2020

2121
// import { Header } from "@/lib/components/header";
22-
import { FirebaseUIProviderHoc } from "@/lib/firebase/ui";
22+
import { FirebaseUIProviderWrapper } from "@/lib/firebase/FirebaseUIProviderWrapper";
2323
import "./globals.css";
2424
// import { useUser } from "@/lib/firebase/hooks";
2525

@@ -49,7 +49,7 @@ export default async function RootLayout({
4949
<html lang="en">
5050
<body className={`${geistSans.variable} ${geistMono.variable} antialiased`}>
5151
{/* <Header currentUser={{null}} /> */}
52-
<FirebaseUIProviderHoc>{children}</FirebaseUIProviderHoc>
52+
<FirebaseUIProviderWrapper>{children}</FirebaseUIProviderWrapper>
5353
</body>
5454
</html>
5555
);

‎examples/nextjs/app/register/page.tsx‎

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,8 @@
1616

1717
"use client";
1818

19-
import { useUser } from "@/lib/firebase/hooks";
20-
import { redirect } from "next/navigation";
2119
import RegisterScreen from "./screen";
2220

23-
export default async function RegisterPage() {
24-
const user = await useUser();
25-
26-
if (user) {
27-
return redirect("/");
28-
}
29-
21+
export default function RegisterPage() {
3022
return <RegisterScreen />;
3123
}

‎examples/nextjs/app/sign-in/email/page.tsx‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,8 @@
1616

1717
"use client";
1818

19-
import { useRouter } from "next/navigation";
20-
import { useEffect } from "react";
2119
import EmailLinkAuthScreen from "./screen";
22-
import { useUser } from "@/lib/firebase/hooks";
2320

2421
export default function SignInWithEmailLinkPage() {
25-
const user = useUser();
26-
const router = useRouter();
27-
28-
useEffect(() => {
29-
if (user) {
30-
router.push("/");
31-
}
32-
}, [user, router]);
33-
34-
if (user) {
35-
return null;
36-
}
37-
3822
return <EmailLinkAuthScreen />;
3923
}

‎examples/nextjs/app/sign-in/page.tsx‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,8 @@
1616

1717
"use client";
1818

19-
import { useRouter } from "next/navigation";
20-
import { useEffect } from "react";
2119
import SignInScreen from "./screen";
22-
import { useUser } from "@/lib/firebase/hooks";
2320

2421
export default function SignInPage() {
25-
const user = useUser();
26-
const router = useRouter();
27-
28-
useEffect(() => {
29-
if (user) {
30-
router.push("/");
31-
}
32-
}, [user, router]);
33-
34-
if (user) {
35-
return null;
36-
}
37-
3822
return <SignInScreen />;
3923
}

‎examples/nextjs/app/sign-in/phone/page.tsx‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,8 @@
1616

1717
"use client";
1818

19-
import { useRouter } from "next/navigation";
20-
import { useEffect } from "react";
2119
import SignInWithPhoneNumberScreen from "./screen";
22-
import { useUser } from "@/lib/firebase/hooks";
2320

2421
export default function SignInWithPhoneNumberPage() {
25-
const user = useUser();
26-
const router = useRouter();
27-
28-
useEffect(() => {
29-
if (user) {
30-
router.push("/");
31-
}
32-
}, [user, router]);
33-
34-
if (user) {
35-
return null;
36-
}
37-
3822
return <SignInWithPhoneNumberScreen />;
3923
}

‎examples/nextjs/firebase.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"hosting": {
3-
"site": "fir-ui-2025-nextjs",
4-
"source": ".",
3+
"site": "fir-ui-rework-nextjs-ssg",
4+
"public": "out",
55
"ignore": ["firebase.json", "**/.*", "**/node_modules/**"]
66
}
77
}

0 commit comments

Comments
 (0)