Skip to content

Commit 2d7d430

Browse files
author
Nicolas Garnier
committed
Some fixes.
1 parent a9f65ed commit 2d7d430

File tree

4 files changed

+26
-10
lines changed

4 files changed

+26
-10
lines changed

.eslintrc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,10 @@
22
"extends": [
33
"plugin:flowtype/recommended",
44
"google",
5-
"prettier",
6-
"prettier/react",
75
"plugin:react/recommended"
86
],
97
"plugins": [
10-
"flowtype",
11-
"prettier"
8+
"flowtype"
129
],
1310
"parser": "babel-eslint",
1411
"parserOptions": {

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
# FirebaseUI Web -- Auth for React
1+
# FirebaseUI React Components
22

3-
FirebaseUI for react provides a React Wrapper on top of the [Firebase UI Web library](https://github.com/firebase/firebaseui-web/) and notably Firebase UI Auth.
3+
FirebaseUI React Components provides a React Wrapper on top of the [Firebase UI Web library](https://github.com/firebase/firebaseui-web/) and notably Firebase UI Auth.
44

55
FirebaseUI Auth provides a drop-in auth solution that handles the UI flows for signing in users with email addresses and passwords, and Identity Provider Sign In using Google, Facebook and others. It is built on top of Firebase Auth.
66

package.json

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,26 @@
3030
"devDependencies": {
3131
"babel-cli": "^6.26.0",
3232
"babel-core": "6.24.1",
33+
"babel-eslint": "7.2.3",
3334
"babel-plugin-dynamic-import-node": "1.0.2",
3435
"babel-plugin-syntax-dynamic-import": "6.18.0",
3536
"babel-plugin-transform-class-properties": "6.24.1",
3637
"babel-plugin-transform-es2015-modules-commonjs": "6.24.1",
3738
"babel-plugin-transform-object-rest-spread": "^6.26.0",
3839
"babel-preset-env": "1.5.1",
39-
"babel-preset-react": "6.24.1"
40+
"babel-preset-react": "6.24.1",
41+
"eslint": "^4.2.0",
42+
"eslint-config-google": "0.9.1",
43+
"eslint-config-react": "1.1.7",
44+
"eslint-config-standard": "^10.2.1",
45+
"eslint-config-standard-react": "^5.0.0",
46+
"eslint-plugin-flow": "2.29.1",
47+
"eslint-plugin-flowtype": "2.35.0",
48+
"eslint-plugin-import": "2.7.0",
49+
"eslint-plugin-jsx-a11y": "6.0.2",
50+
"eslint-plugin-node": "^5.1.1",
51+
"eslint-plugin-promise": "^3.5.0",
52+
"eslint-plugin-react": "^7.1.0",
53+
"eslint-plugin-standard": "^3.0.1"
4054
}
4155
}

src/FirebaseAuth.jsx

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16+
// @flow
17+
1618
import React from 'react';
1719

1820
// Global ID for the element.
@@ -46,7 +48,8 @@ export default class FirebaseAuth extends React.Component {
4648

4749
// Firebase UI only works on the Client. So we're loading in `componentDidMount`.
4850
const firebaseui = require('firebaseui');
49-
this.firebaseUiWidget = firebaseui.auth.AuthUI.getInstance() || new firebaseui.auth.AuthUI(this.firebaseAuth);
51+
this.firebaseUiWidget = firebaseui.auth.AuthUI.getInstance()
52+
|| new firebaseui.auth.AuthUI(this.firebaseAuth);
5053
this.firebaseUiWidget.reset();
5154
this.firebaseUiWidget.start('#' + this.elementId, this.uiConfig);
5255
}
@@ -62,9 +65,11 @@ export default class FirebaseAuth extends React.Component {
6265
* Properties types.
6366
*/
6467
props: {
65-
uiConfig: Object, // The Firebase UI Web UI Config object. See: https://github.com/firebase/firebaseui-web#configuration
68+
uiConfig: Object, // The Firebase UI Web UI Config object.
69+
// See: https://github.com/firebase/firebaseui-web#configuration
6670
firebaseAuth: Object, // The Firebase App auth instance to use.
67-
elementId?: String // The ID of the underlying container that we'll generate. Use this if you use more than one instance at a time in your app.
71+
elementId?: String // The ID of the underlying container that we'll generate.
72+
// Use this if you use more than one instance at a time in your app.
6873
};
6974

7075
/**

0 commit comments

Comments
 (0)