Update min Unity version and remove dotnet 3 support (#485)

* Remove dotnet 3 support

* Update testapp readmes

* Add missing newline

Author: a-maurice

analytics/CMakeLists.txt

@@ -43,8 +43,6 @@ mono_add_library(firebase_analytics_cs
     ${firebase_analytics_src}
     ${firebase_analytics_swig_gen_src}
   REFERENCES
-    unity_compat_cs
-    unity_tasks_cs
     ${FIREBASE_PLATFORM_REF}
   DEPENDS
     firebase_analytics_swig

analytics/testapp/readme.md

@@ -51,13 +51,7 @@ with the
   - Import the `Firebase Analytics` plugin.
     - Select the **Assets > Import Package > Custom Package** menu item.
     - From the [Firebase Unity SDK](https://firebase.google.com/download/unity)
-      downloaded previously, import `FirebaseAnalytics.unitypackage` from the
-      directory that matches the version of Unity you use:
-       - Unity 5.x and earlier use the .NET 3.x framework, so you need to
-         import the `dotnet3/FirebaseAnalytics.unitypackage` package .
-       - Unity 2017.x and newer allow the use of the .NET 4.x framework.  If
-         your project is configured to use .NET 4.x, import the
-         `dotnet4/FirebaseAnalytics.unitypackage` package.
+      downloaded previously, import `FirebaseAnalytics.unitypackage`.
     - When the **Import Unity Package** window appears, click the **Import**
       button.
   - Add the `GoogleService-Info.plist` file to the project.
@@ -143,13 +137,7 @@ with the
   - Import the `Firebase Analytics` plugin.
     - Select the **Assets > Import Package > Custom Package** menu item.
     - From the [Firebase Unity SDK](https://firebase.google.com/download/unity)
-      downloaded previously, import `FirebaseAnalytics.unitypackage` from the
-      directory that matches the version of Unity you use:
-       - Unity 5.x and earlier use the .NET 3.x framework, so you need to
-         import the `dotnet3/FirebaseAnalytics.unitypackage` package .
-       - Unity 2017.x and newer allow the use of the .NET 4.x framework.  If
-         your project is configured to use .NET 4.x, import the
-         `dotnet4/FirebaseAnalytics.unitypackage` package.
+      downloaded previously, import `FirebaseAnalytics.unitypackage`.
     - When the **Import Unity Package** window appears, click the **Import**
       button.
   - Add the `google-services.json` file to the project.

app/CMakeLists.txt

@@ -95,8 +95,6 @@ mono_add_library(firebase_app_cs
     ${firebase_app_swig_gen_src}
     ${version_info_file}
   REFERENCES
-    unity_compat_cs
-    unity_tasks_cs
     ${firebase_platform_task_lib}
     firebase_platform_cs
     firebase_taskextension_cs

app/platform/CMakeLists.txt

@@ -64,8 +64,6 @@ mono_add_library(firebase_platform_cs
     ${firebase_platform_src}
   REFERENCES
     google_minijson_cs
-    unity_compat_cs
-    unity_tasks_cs
     ${firebase_platform_task_lib}
 )
 

app/task_extension/CMakeLists.txt

@@ -24,8 +24,6 @@ mono_add_library(firebase_taskextension_cs
   SOURCES
     ${firebase_taskextension_src}
   REFERENCES
-    unity_compat_cs
-    unity_tasks_cs
     ${firebase_platform_task_lib}
     firebase_platform_cs
   XBUILD_EXE

auth/CMakeLists.txt

@@ -57,8 +57,6 @@ mono_add_library(firebase_auth_cs
     ${firebase_auth_src}
     ${firebase_auth_swig_gen_src}
   REFERENCES
-    unity_compat_cs
-    unity_tasks_cs
     ${FIREBASE_PLATFORM_REF}
   DEPENDS
     firebase_auth_swig

auth/testapp/readme.md

@@ -57,13 +57,7 @@ with the
   - Import the `Firebase Auth` plugin.
     - Select the **Assets > Import Package > Custom Package** menu item.
     - From the [Firebase Unity SDK](https://firebase.google.com/download/unity)
-      downloaded previously, import `FirebaseAuth.unitypackage` from the
-      directory that matches the version of Unity you use:
-       - Unity 5.x and earlier use the .NET 3.x framework, so you need to
-         import the `dotnet3/FirebaseAuth.unitypackage` package .
-       - Unity 2017.x and newer allow the use of the .NET 4.x framework.  If
-         your project is configured to use .NET 4.x, import the
-         `dotnet4/FirebaseAuth.unitypackage` package.
+      downloaded previously, import `FirebaseAuth.unitypackage`.
     - When the **Import Unity Package** window appears, click the **Import**
       button.
   - Add the `GoogleService-Info.plist` file to the project.
@@ -157,13 +151,7 @@ with the
   - Import the `Firebase Auth` plugin.
     - Select the **Assets > Import Package > Custom Package** menu item.
     - From the [Firebase Unity SDK](https://firebase.google.com/download/unity)
-      downloaded previously, import `FirebaseAuth.unitypackage` from the
-      directory that matches the version of Unity you use:
-       - Unity 5.x and earlier use the .NET 3.x framework, so you need to
-         import the `dotnet3/FirebaseAuth.unitypackage` package .
-       - Unity 2017.x and newer allow the use of the .NET 4.x framework.  If
-         your project is configured to use .NET 4.x, import the
-         `dotnet4/FirebaseAuth.unitypackage` package.
+      downloaded previously, import `FirebaseAuth.unitypackage`.
     - When the **Import Unity Package** window appears, click the **Import**
       button.
   - Add the `google-services.json` file to the project.

cmake/external/CMakeLists.txt

@@ -25,4 +25,3 @@ list(APPEND CMAKE_MODULE_PATH ${CMAKE_CURRENT_LIST_DIR})
 include(firebase_cpp_sdk)
 include(google_unity_jar_resolver)
 include(minijson)
-include(parse)

cmake/external/parse.cmake

@@ -199,7 +199,7 @@ endmacro()
 #  sys_references: System CSharp libraries this depends on
 #  dep_targets: Targets this target depends on and need to be linked/built first
 #  guid: MSBuild project guid (for use with solution files)
-#  framework_version: .net framework version, defaults to 3.5
+#  framework_version: .net framework version, defaults to 4.5
 #  defines: Extra defines to add to the project file
 #  assembly_name: Name of the output assembly. Defaults to module
 #  xbuild: Path to xbuild executable. Defaults to XBUILD_EXE global var
@@ -250,7 +250,7 @@ macro(mono_add_internal name output_type)
   endif()
 
   if ("${UNITY_MONO_FRAMEWORK_VERSION}" STREQUAL "")
-    set(UNITY_MONO_FRAMEWORK_VERSION "3.5")
+    set(UNITY_MONO_FRAMEWORK_VERSION "4.5")
   endif()
 
   if ("${UNITY_MONO_ASSEMBLY_NAME}" STREQUAL "")