fix package step and nightly build (#354)

Author: cynthiajoan

.github/workflows/build_starter.yml

@@ -75,9 +75,15 @@ jobs:
         run: pip install -r scripts/gha/requirements.txt
       - id: set_outputs
         run: |
-          platform=$( python scripts/gha/print_matrix_configuration.py -c -w config -k platform -o "${{ github.event.inputs.platforms }}" )
-          echo "::set-output name=platform::${platform}"
-          echo "::set-output name=release_label::${{ github.event.inputs.release_version }}-${{ github.event.inputs.rc_index }}"
+          if [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then
+            platform=$( python scripts/gha/print_matrix_configuration.py -c -w config -k platform -o "${{ github.event.inputs.platforms }}" )
+            echo "::set-output name=platform::${platform}"
+            echo "::set-output name=release_label::${{ github.event.inputs.release_version }}-${{ github.event.inputs.rc_index }}"
+          else
+            echo "::set-output name=platform::'Android,iOS,Windows,macOS,Linux'"
+            echo "::set-output name=release_label::nightly-$(date "+%Y%m%d-%H%M%S")"
+          fi
+          
       - name: Print output
         run: |
           echo outputs.platform : ${{ steps.set_outputs.outputs.platform }}

.github/workflows/package.yml

@@ -304,6 +304,7 @@ jobs:
           python build_package.py --zip_dir=built_artifact
 
       - name: Commit Changes if there is any
+        if: steps.decide_input.outputs.working_branch != '' || steps.decide_input.outputs.create_new_branch == '1'
         run: |
           if ! git update-index --refresh; then
             git config user.email "firebase-workflow-trigger-bot@google.com"
@@ -318,7 +319,7 @@ jobs:
           fi
 
       - name: Create PR if there is None
-        if: steps.decide_input.outputs.working_branch == '' && steps.decide_input.outputs.create_new_branch == '1'
+        if: steps.decide_input.outputs.working_branch != '' || steps.decide_input.outputs.create_new_branch == '1'
         id: push-branch
         run: |
           if ! git update-index --refresh; then