Make one workflow to create release (#340)

cynthiajoan · web-flow · commit 1ce13e7d5b2f · 2022-06-06T11:04:32.000-07:00
diff --git a/.github/workflows/build_starter.yml b/.github/workflows/build_starter.yml
@@ -12,7 +12,7 @@ on:
         default: '2019'
         required: true
       firebase_cpp_sdk_version:
-        description: 'Firebase CPP SDK version to build against (The branch, tag or SHA to checkout)'
+        description: 'Firebase CPP SDK version to build against (The branch, tag or SHA to checkout). Required if for release'
         default: ''
         required: false
       unity_branch:
@@ -32,9 +32,14 @@ on:
         description: 'Additional flags to pass into CMake'
         default: ''
         required: false
-      release_label:
-        description: 'If the package is intended to run for a release, put <version>-RC## for label'
-        default: 'NoneRelease'
+      release_version:
+        description: 'If the package is intended to run for a release, put <version> number like 9.1.0'
+        default: 'NoVersion'
+        type: string
+        required: true
+      rc_index:
+        description: 'If the package is intended to run for a release, put RC## for label'
+        default: 'NA'
         type: string
         required: true
       should_trigger_package:
@@ -55,6 +60,7 @@ jobs:
     runs-on: ubuntu-latest
     outputs:
       platform: ${{ steps.set_outputs.outputs.platform }}
+      release_label: ${{ steps.set_outputs.outputs.release_label }}
     steps:
       - uses: actions/checkout@v2
         with:
@@ -69,52 +75,79 @@ jobs:
         run: pip install -r scripts/gha/requirements.txt
       - id: set_outputs
         run: |
-          platform=$( python scripts/gha/print_matrix_configuration.py -c -w build_unity_sdks -k platform -o "${{github.event.inputs.platforms}}" )
+          platform=$( python scripts/gha/print_matrix_configuration.py -c -w build_unity_sdks -k platform -o "${{ github.event.inputs.platforms }}" )
           echo "::set-output name=platform::${platform}"
+          echo "::set-output name=release_label::${{ github.event.inputs.release_version }}-${{ github.event.inputs.rc_index }}"
+  
+  update_versions:
+    uses: ./.github/workflows/update_versions.yml
+    needs: check_and_prepare
+    if: (github.event.inputs.release_version!='NoVersion')
+    with:
+      triggered_by_callable: true
+      base_branch: ${{ github.event.inputs.unity_branch }}
+      package_version_number: ${{ github.event.inputs.release_version }}
+      cpp_release_version: ${{ github.event.inputs.firebase_cpp_sdk_version }}
+    secrets: inherit
+
+  decide_build_branch:
+    needs: update_versions
+    runs-on: ubuntu-latest
+    outputs: 
+      build_branch: ${{ steps.decide_branch.outputs.branch }}
+    steps:
+      - id: decide_branch
+        run: |
+          if [[ "${{ github.event.inputs.release_version }}" == "'NoVersion'" ]]; then
+            # Triggered by callable
+            echo "::set-output name=branch::${{ github.event.inputs.unity_branch }}"
+          else
+            echo "::set-output name=branch::${{ needs.update_versions.outputs.new_branch }}"
+          fi
 
   build_android:
     name: build-android-unity${{ github.event.inputs.unity_version }}-CPP${{ github.event.inputs.firebase_cpp_sdk_version }}
     uses: ./.github/workflows/build_android.yml
-    needs: check_and_prepare
+    needs: [check_and_prepare, decide_build_branch]
     if: contains(needs.check_and_prepare.outputs.platform, 'Android')
     with:
       unity_version: ${{ github.event.inputs.unity_version }}
       firebase_cpp_sdk_version: ${{ github.event.inputs.firebase_cpp_sdk_version }}
-      unity_branch: ${{ github.event.inputs.unity_branch }}
+      unity_branch: ${{ needs.decide_build_branch.outputs.build_branch }}
       apis: ${{ github.event.inputs.apis }}
       unity_platform_name: Android
       additional_cmake_flags: ${{ github.event.inputs.additional_cmake_flags }}
   
   build_ios:
     name: build-ios-unity${{ github.event.inputs.unity_version }}-CPP${{ github.event.inputs.firebase_cpp_sdk_version }}
     uses: ./.github/workflows/build_ios.yml
-    needs: check_and_prepare
+    needs: [check_and_prepare, decide_build_branch]
     if: contains(needs.check_and_prepare.outputs.platform, 'iOS')
     with:
       unity_version: ${{ github.event.inputs.unity_version }}
       firebase_cpp_sdk_version: ${{ github.event.inputs.firebase_cpp_sdk_version }}
-      unity_branch: ${{ github.event.inputs.unity_branch }}
+      unity_branch: ${{ needs.decide_build_branch.outputs.build_branch }}
       apis: ${{ github.event.inputs.apis }}
       unity_platform_name: iOS
       additional_cmake_flags: ${{ github.event.inputs.additional_cmake_flags }}
 
   build_linux:
     name: build-linux-unity${{ github.event.inputs.unity_version }}-CPP${{ github.event.inputs.firebase_cpp_sdk_version }}
     uses: ./.github/workflows/build_linux.yml
-    needs: check_and_prepare
+    needs: [check_and_prepare, decide_build_branch]
     if: contains(needs.check_and_prepare.outputs.platform, 'Linux')
     with:
       unity_version: ${{ github.event.inputs.unity_version }}
       firebase_cpp_sdk_version: ${{ github.event.inputs.firebase_cpp_sdk_version }}
-      unity_branch: ${{ github.event.inputs.unity_branch }}
+      unity_branch: ${{ needs.decide_build_branch.outputs.build_branch }}
       apis: ${{ github.event.inputs.apis }}
       unity_platform_name: Linux
       additional_cmake_flags: ${{ github.event.inputs.additional_cmake_flags }}
 
   build_macos:
     name: build-macos-unity${{ github.event.inputs.unity_version }}-CPP${{ github.event.inputs.firebase_cpp_sdk_version }}
     uses: ./.github/workflows/build_macos.yml
-    needs: check_and_prepare
+    needs: [check_and_prepare, decide_build_branch]
     if: contains(needs.check_and_prepare.outputs.platform, 'macOS')
     with:
       unity_version: ${{ github.event.inputs.unity_version }}
@@ -127,24 +160,25 @@ jobs:
   build_windows:
     name: build-windows-unity${{ github.event.inputs.unity_version }}-CPP${{ github.event.inputs.firebase_cpp_sdk_version }}
     uses: ./.github/workflows/build_windows.yml
-    needs: check_and_prepare
+    needs: [check_and_prepare, decide_build_branch]
     if: contains(needs.check_and_prepare.outputs.platform, 'Windows')
     with:
       unity_version: ${{ github.event.inputs.unity_version }}
       firebase_cpp_sdk_version: ${{ github.event.inputs.firebase_cpp_sdk_version }}
-      unity_branch: ${{ github.event.inputs.unity_branch }}
+      unity_branch: ${{ needs.decide_build_branch.outputs.build_branch }}
       apis: ${{ github.event.inputs.apis }}
       unity_platform_name: Windows
       additional_cmake_flags: ${{ github.event.inputs.additional_cmake_flags }}
 
   trigger_reusable_package:
-    name: package ${{ github.event.inputs.release_label }}
-    needs: [build_android, build_ios, build_linux, build_macos, build_windows]
+    name: package ${{ needs.check_and_prepare.outputs.release_label }}
+    needs: [build_android, build_ios, build_linux, build_macos, build_windows, decide_build_branch]
     uses: ./.github/workflows/package.yml
     if: (github.event.inputs.should_trigger_package == 'true') && !cancelled() && !failure()
     with:
       triggered_by_callable: true
-      release_label: ${{ github.event.inputs.release_label }}
+      release_label: ${{ needs.check_and_prepare.outputs.release_label }}
       skipIntegrationTests: ${{ github.event.inputs.skipIntegrationTests }}
       build_run_id: ${{ github.run_id }}
+      working_branch: ${{ needs.decide_build_branch.outputs.build_branch }}
     secrets: inherit
diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml
@@ -89,6 +89,7 @@ jobs:
           if [[ "${{ inputs.triggered_by_callable }}" == "true" ]]; then
             # Triggered by callable
             echo "::set-output name=use_new_build::'1'"
+            echo "::set-output name=workflow_conclusion::in_progress" 
             echo "::set-output name=skipIntegrationTests::${{ inputs.skipIntegrationTests }}"
             echo "::set-output name=create_new_branch::${{ inputs.create_new_branch }}"
             echo "::set-output name=release_label::${{ inputs.release_label }}"
@@ -100,6 +101,7 @@ jobs:
             echo "::set-output name=download_windows_run::${{ inputs.build_run_id }}"
           else
             echo "::set-output name=use_new_build::${{ github.event.inputs.use_new_build }}"
+            echo "::set-output name=workflow_conclusion::success"
             echo "::set-output name=skipIntegrationTests::${{ github.event.inputs.skipIntegrationTests }}"
             echo "::set-output name=create_new_branch::${{ github.event.inputs.create_new_branch }}"
             echo "::set-output name=release_label::${{ github.event.inputs.release_label }}"
@@ -116,6 +118,7 @@ jobs:
         run: |
           echo triggered_by_callable: ${{ inputs.triggered_by_callable }}
           echo use_new_build: ${{ steps.decide_input.outputs.use_new_build }}
+          echo workflow_conclusion: ${{ steps.decide_input.outputs.workflow_conclusion }}
           echo skipIntegrationTests: ${{ steps.decide_input.outputs.skipIntegrationTests }}
           echo create_new_branch: ${{ steps.decide_input.outputs.create_new_branch }}
           echo release_label: ${{ steps.decide_input.outputs.release_label }}
@@ -175,74 +178,117 @@ jobs:
           git checkout ${{ steps.decide_input.outputs.working_branch }}
           echo "UPDATE_LOGFILE=update_log.txt" >> $GITHUB_ENV
           echo "NEW_BRANCH=${{ steps.decide_input.outputs.working_branch }}" >> $GITHUB_ENV
-
-      - name: Set Fetch Workflow name
-        id: set-fetch-workflow
-        shell: bash
-        run: |
-          if [[ "${{ steps.decide_input.outputs.use_new_build }}" == "1" ]]; then
-            # all use build_starter.yml
-            echo "::set-output name=android_yml::'build_starter.yml'"
-            echo "::set-output name=ios_yml::'build_starter.yml'"
-            echo "::set-output name=linux_yml::'build_starter.yml'"
-            echo "::set-output name=macos_yml::'build_starter.yml'"
-            echo "::set-output name=windows_yml::'build_starter.yml'"
-          else
-            echo "::set-output name=android_yml::'android.yml'"
-            echo "::set-output name=ios_yml::'ios.yml'"
-            echo "::set-output name=linux_yml::'sdk_build.yml'"
-            echo "::set-output name=macos_yml::'sdk_build.yml'"
-            echo "::set-output name=windows_yml::'sdk_build.yml'"
-          fi
       
-      - name: Fetch Android Artifacts
+      - name: Fetch Android Artifacts (OLD)
         uses: dawidd6/action-download-artifact@v2
         continue-on-error: true
+        if: (inputs.triggered_by_callable==false) && (steps.decide_input.outputs.use_new_build=='0')
         with:
-          workflow: ${{ steps.set-fetch-workflow.outputs.android_yml }}
+          workflow: android.yml
           run_id: ${{ steps.decide_input.outputs.download_android_run }}
           name: android_unity
-          path: built_artifect
+          path: built_artifact
       
-      - name: Fetch iOS Artifacts
+      - name: Fetch iOS Artifacts (OLD)
         uses: dawidd6/action-download-artifact@v2
         continue-on-error: true
+        if: (inputs.triggered_by_callable==false) && (steps.decide_input.outputs.use_new_build=='0')
         with:
-          workflow: ${{ steps.set-fetch-workflow.outputs.ios_yml }}
+          workflow: ios.yml
           run_id: ${{ steps.decide_input.outputs.download_ios_run }}
           name: ios_unity
-          path: built_artifect
+          path: built_artifact
 
-      - name: Fetch Linux Artifacts
+      - name: Fetch Linux Artifacts (OLD)
         uses: dawidd6/action-download-artifact@v2
         continue-on-error: true
+        if: (inputs.triggered_by_callable==false) && (steps.decide_input.outputs.use_new_build=='0')
         with:
-          workflow: ${{ steps.set-fetch-workflow.outputs.linux_yml }}
+          workflow: sdk_build.yml
           run_id: ${{ steps.decide_input.outputs.download_linux_run }}
           name: linux_unity
-          path: built_artifect
+          path: built_artifact
 
-      - name: Fetch MacOS Artifacts
+      - name: Fetch MacOS Artifacts (OLD)
         uses: dawidd6/action-download-artifact@v2
         continue-on-error: true
+        if: (inputs.triggered_by_callable==false) && (steps.decide_input.outputs.use_new_build=='0')
         with:
-          workflow: ${{ steps.set-fetch-workflow.outputs.macos_yml }}
+          workflow: sdk_build.yml
           run_id: ${{ steps.decide_input.outputs.download_macos_run }}
           name: macos_unity
-          path: built_artifect
+          path: built_artifact
 
-      - name: Fetch Windows Artifacts
+      - name: Fetch Windows Artifacts (OLD)
         uses: dawidd6/action-download-artifact@v2
         continue-on-error: true
+        if: (inputs.triggered_by_callable==false) && (steps.decide_input.outputs.use_new_build=='0')
         with:
-          workflow: ${{ steps.set-fetch-workflow.outputs.windows_yml }}
+          workflow: sdk_build.yml
           run_id: ${{ steps.decide_input.outputs.download_windows_run }}
           name: windows_unity
-          path: built_artifect
+          path: built_artifact
+
+      - name: Fetch Android Artifacts (NEW)
+        uses: dawidd6/action-download-artifact@v2
+        continue-on-error: true
+        if: (inputs.triggered_by_callable==false) && (steps.decide_input.outputs.use_new_build=='1')
+        with:
+          workflow: build_starter.yml
+          run_id: ${{ steps.decide_input.outputs.download_android_run }}
+          name: android_unity
+          path: built_artifact
+      
+      - name: Fetch iOS Artifacts (NEW)
+        uses: dawidd6/action-download-artifact@v2
+        continue-on-error: true
+        if: (inputs.triggered_by_callable==false) && (steps.decide_input.outputs.use_new_build=='1')
+        with:
+          workflow: build_starter.yml
+          run_id: ${{ steps.decide_input.outputs.download_ios_run }}
+          name: ios_unity
+          path: built_artifact
+
+      - name: Fetch Linux Artifacts (NEW)
+        uses: dawidd6/action-download-artifact@v2
+        continue-on-error: true
+        if: (inputs.triggered_by_callable==false) && (steps.decide_input.outputs.use_new_build=='1')
+        with:
+          workflow: build_starter.yml
+          run_id: ${{ steps.decide_input.outputs.download_linux_run }}
+          name: linux_unity
+          path: built_artifact
+
+      - name: Fetch MacOS Artifacts (NEW)
+        uses: dawidd6/action-download-artifact@v2
+        continue-on-error: true
+        if: (inputs.triggered_by_callable==false) && (steps.decide_input.outputs.use_new_build=='1')
+        with:
+          workflow: build_starter.yml
+          run_id: ${{ steps.decide_input.outputs.download_macos_run }}
+          name: macos_unity
+          path: built_artifact
+
+      - name: Fetch Windows Artifacts (NEW)
+        uses: dawidd6/action-download-artifact@v2
+        continue-on-error: true
+        if: (inputs.triggered_by_callable==false) && (steps.decide_input.outputs.use_new_build=='1')
+        with:
+          workflow: build_starter.yml
+          run_id: ${{ steps.decide_input.outputs.download_windows_run }}
+          name: windows_unity
+          path: built_artifact
+
+      # If called by build_start.xml, ignore name search, just grab all artifact exists
+      - name: Fetch All in build_starter
+        uses: actions/download-artifact@v3
+        if: inputs.triggered_by_callable==true
+        with:
+          path: built_artifact
       
       - name: move zip files
         run: |
-          cd built_artifect
+          cd built_artifact
           find . -type f -name "*.zip" -exec mv {} . \;
           find . -empty -type d -delete
           ls -lR
@@ -255,7 +301,7 @@ jobs:
 
       - name: Package unitypackage
         run: |
-          python build_package.py --zip_dir=built_artifect
+          python build_package.py --zip_dir=built_artifact
 
       - name: Commit Changes if there is any
         run: |
@@ -330,7 +376,7 @@ jobs:
       
       - name: Package tgz
         run: |
-          python build_package.py --zip_dir=built_artifect --output_upm=True --output=output_tgz
+          python build_package.py --zip_dir=built_artifact --output_upm=True --output=output_tgz
 
       - name: Listing output tgz
         run: |
diff --git a/.github/workflows/update_versions.yml b/.github/workflows/update_versions.yml
