Fix an issue with bitcode not being enabled (#338)

Author: a-maurice

CMakeLists.txt

@@ -234,7 +234,7 @@ endif()
 
 # Includes platform which needs to be invoked first
 add_subdirectory(app)
-set(TARGET_LINK_LIB_NAMES "firebase_app" "firebase_app_swig" "flatbuffers")
+set(TARGET_LINK_LIB_NAMES "firebase_app" "firebase_app_swig")
 set(PROJECT_LIST_HEADER "#define PROJECT_LIST(X)")
 list(APPEND PROJECT_LIST_HEADER "  X(App)")
 
@@ -301,7 +301,7 @@ endif()
 
 if(FIREBASE_UNI_LIBRARY)
   if(FIREBASE_IOS_BUILD)
-    ios_pack(firebase_lib_uni libFirebaseCppApp DEPS "firebase_app" "firebase_app_swig" "flatbuffers")
+    ios_pack(firebase_lib_uni libFirebaseCppApp DEPS "firebase_app" "firebase_app_swig")
   else()
     build_uni(
       "${TARGET_LINK_LIB_NAMES}"

cmake/build_shared.cmake

@@ -79,6 +79,12 @@ function(build_firebase_shared LIBRARY_NAME ARTIFACT_NAME OUTPUT_NAME)
         PREFIX "lib"
         SUFFIX ".a"
     )
+
+    # Enable Automatic Reference Counting (ARC) and Bitcode.
+    target_compile_options(${shared_target}
+                           PUBLIC "-fobjc-arc" "-fembed-bitcode")
+    target_link_libraries(${shared_target}
+                          PUBLIC "-fembed-bitcode")
   elseif(ANDROID)
     set_target_properties(${shared_target}
       PROPERTIES
@@ -125,4 +131,4 @@ function(build_firebase_shared LIBRARY_NAME ARTIFACT_NAME OUTPUT_NAME)
     )
   endif()
 
-endfunction()
+endfunction()

docs/readme.md

@@ -158,6 +158,7 @@ Release Notes
 ### Upcoming
 - Changes
     - General: Added a missing namespace to the Google.MiniJson.dll.
+    - General (iOS): Fix an issue with bitcode not being enabled correctly.
     - Functions: Add a new method `GetHttpsCallableFromURL`, to create callables
       with URLs other than cloudfunctions.net.
     - Analytics (iOS): Added InitiateOnDeviceConversionMeasurementWithEmail function to facilitate the