Change the Messaging topic test to avoid accidental messages (#805)

* Use a unique topic in Messaging tests

* Change Messaging Topic tests

* Update UIHandlerAutomated.cs

* Typo in comment

Author: a-maurice

messaging/testapp/Assets/Firebase/Sample/Messaging/UIHandler.cs

@@ -33,6 +33,13 @@ class UIHandler : MonoBehaviour {
     private string topic = "TestTopic";
     private bool UIEnabled = true;
 
+    // Should this Subscribe to the topic on startup.
+    protected virtual bool SubscribeToTopicOnStart {
+      get {
+        return true;
+      }
+    }
+
     // Log the result of the specified task, returning true if the task
     // completed successfully, false otherwise.
     protected bool LogTaskCompletion(Task task, string operation) {
@@ -87,9 +94,11 @@ void InitializeFirebase() {
         task => {
           LogTaskCompletion(task, "RequestPermissionAsync");
 
-          Firebase.Messaging.FirebaseMessaging.SubscribeAsync(topic).ContinueWithOnMainThread(task => {
-            LogTaskCompletion(task, "SubscribeAsync");
-          });
+          if (SubscribeToTopicOnStart) {
+            Firebase.Messaging.FirebaseMessaging.SubscribeAsync(topic).ContinueWithOnMainThread(task => {
+              LogTaskCompletion(task, "SubscribeAsync");
+            });
+          }
         }
       );
       isFirebaseInitialized = true;

messaging/testapp/Assets/Firebase/Sample/Messaging/UIHandlerAutomated.cs

@@ -34,6 +34,13 @@ public class UIHandlerAutomated : UIHandler {
     private string registrationToken;
     private FirebaseMessage lastReceivedMessage;
 
+    // Don't subscribe to a topic, since it might confuse the tests.
+    protected override bool SubscribeToTopicOnStart {
+      get {
+        return false;
+      }
+    }
+
     protected override void Start() {
 #if FIREBASE_RUNNING_FROM_CI && (UNITY_IOS || UNITY_TVOS)
       // Messaging on iOS requires user interaction to give permissions
@@ -177,13 +184,21 @@ IEnumerator TestSendJsonMessageToDevice(TaskCompletionSource<string> tcs) {
     // waits until the app receives the message and verifies the contents are the same as were sent.
     IEnumerator TestSendJsonMessageToSubscribedTopic(TaskCompletionSource<string> tcs) {
       yield return StartCoroutine(WaitForToken());
-      SendJsonMessageToTopicAsync(JsonMessageB, TestTopic);
+      // Note: Ideally this would use a more unique topic, but topic creation and subscription
+      // takes additional time, so instead this only subscribes during this one test, and doesn't
+      // fully test unsubscribing.
+      Firebase.Messaging.FirebaseMessaging.SubscribeAsync(TestTopic).ContinueWithOnMainThread(t => {
+        SendJsonMessageToTopicAsync(JsonMessageB, TestTopic);
+      });
       // TODO(b/65218400): check message id.
       while (lastReceivedMessage == null) {
         yield return new WaitForSeconds(0.5f);
       }
-      ValidateJsonMessageB(tcs, lastReceivedMessage);
-      lastReceivedMessage = null;
+      // Unsubscribe from the test topic, to make sure that other messages aren't received.
+      Firebase.Messaging.FirebaseMessaging.UnsubscribeAsync(TestTopic).ContinueWithOnMainThread(t => {
+        ValidateJsonMessageB(tcs, lastReceivedMessage);
+        lastReceivedMessage = null;
+      });
     }
 
     // Fake test (always passes immediately). Can be used on platforms with no other tests.