build_testapps.py suppresses Dynamic Links on tvOS (#599)

This change updates the build_testapps.py to suppress its build of Dynamic Links even if its passed in as one the provided targets on tvOS.

Author: DellaBitta

scripts/gha/build_testapps.py

@@ -327,6 +327,11 @@ def main(argv):
         continue  # If setup failed, don't try to build. Move to next testapp.
       for p in platforms:
         try:
+          if p not in api_config.platforms:
+            logging.warning(
+              "Skipping {0} on {1} as it's not in the platform config.".format(
+              testapp, p))
+            continue
           if p == _DESKTOP:  # e.g. 'Desktop' -> 'OSXUniversal'
             p = get_desktop_platform()
           if p == _PLAYMODE:

scripts/gha/integration_testing/build_testapps.json

@@ -6,6 +6,7 @@
       "captial_name": "Analytics",
       "bundle_id": "com.google.firebase.unity.analytics.testapp",
       "testapp_path": "analytics/testapp",
+      "platforms": ["Android", "Playmode", "iOS", "tvOS", "Desktop"],
       "plugins": [
         "FirebaseAnalytics.unitypackage"
       ],
@@ -22,6 +23,7 @@
       "captial_name": "Auth",
       "bundle_id": "com.google.FirebaseUnityAuthTestApp.dev",
       "testapp_path": "auth/testapp",
+      "platforms": ["Android", "Playmode", "iOS", "tvOS", "Desktop"],
       "plugins": [
         "FirebaseAuth.unitypackage"
       ],
@@ -39,6 +41,7 @@
       "captial_name": "Crashlytics",
       "bundle_id": "com.google.firebase.unity.crashlytics.testapp",
       "testapp_path": "crashlytics/testapp",
+      "platforms": ["Android", "Playmode", "iOS", "tvOS", "Desktop"],
       "plugins": [
         "FirebaseCrashlytics.unitypackage"
       ],
@@ -55,6 +58,7 @@
       "captial_name": "Database",
       "bundle_id": "com.google.firebase.unity.database.testapp",
       "testapp_path": "database/testapp",
+      "platforms": ["Android", "Playmode", "iOS", "tvOS", "Desktop"],
       "plugins": [
         "FirebaseDatabase.unitypackage"
       ],
@@ -72,6 +76,7 @@
       "captial_name": "DynamicLinks",
       "bundle_id": "com.google.FirebaseUnityDynamicLinksTestApp.dev",
       "testapp_path": "dynamic_links/testapp",
+      "platforms": ["Android", "Playmode", "iOS", "Desktop"],
       "plugins": [
         "FirebaseDynamicLinks.unitypackage"
       ],
@@ -89,6 +94,7 @@
       "captial_name": "Firestore",
       "bundle_id": "com.google.firebase.firestore.unity.testapp",
       "testapp_path": "firestore/testapp",
+      "platforms": ["Android", "Playmode", "iOS", "tvOS", "Desktop"],
       "plugins": [
         "FirebaseFirestore.unitypackage",
         "FirebaseAuth.unitypackage"
@@ -108,6 +114,7 @@
       "captial_name": "Functions",
       "bundle_id": "com.google.firebase.unity.functions.testapp",
       "testapp_path": "functions/testapp",
+      "platforms": ["Android", "Playmode", "iOS", "tvOS", "Desktop"],
       "plugins": [
         "FirebaseFunctions.unitypackage",
         "FirebaseAuth.unitypackage"
@@ -126,6 +133,7 @@
       "captial_name": "Installations",
       "bundle_id": "com.google.firebase.unity.fis.testapp",
       "testapp_path": "installations/testapp",
+      "platforms": ["Android", "Playmode", "iOS", "tvOS", "Desktop"],
       "plugins": [
         "FirebaseInstallations.unitypackage"
       ],
@@ -142,6 +150,7 @@
       "captial_name": "Messaging",
       "bundle_id": "com.google.FirebaseUnityMessagingTestApp.dev",
       "testapp_path": "messaging/testapp",
+      "platforms": ["Android", "Playmode", "iOS", "tvOS", "Desktop"],
       "plugins": [
         "FirebaseMessaging.unitypackage"
       ],
@@ -159,6 +168,7 @@
       "captial_name": "RemoteConfig",
       "bundle_id": "com.google.firebase.unity.remoteconfig.testapp",
       "testapp_path": "remote_config/testapp",
+      "platforms": ["Android", "Playmode", "iOS", "tvOS", "Desktop"],
       "plugins": [
         "FirebaseRemoteConfig.unitypackage"
       ],
@@ -175,6 +185,7 @@
       "captial_name": "Storage",
       "bundle_id": "com.google.firebase.unity.storage.testapp",
       "testapp_path": "storage/testapp",
+      "platforms": ["Android", "Playmode", "iOS", "tvOS", "Desktop"],
       "plugins": [
         "FirebaseStorage.unitypackage"
       ],

scripts/gha/integration_testing/config_reader.py

@@ -100,6 +100,7 @@ def read_config(path=None):
           captial_name=api["captial_name"],
           testapp_path=api["testapp_path"],
           plugins=api["plugins"],
+          platforms=api["platforms"],
           bundle_id=api["bundle_id"],
           upm_packages=api.get("upm_packages", None),
           entitlements=api.get("entitlements", None),
@@ -136,6 +137,7 @@ class APIConfig(object):
   captial_name = attr.ib()
   testapp_path = attr.ib()  # Relative path to this testapp's directory
   plugins = attr.ib()  # .unitypackages
+  platforms = attr.ib() # supported platforms
   bundle_id = attr.ib()
   upm_packages = attr.ib()  # Optional package tars for use_local_packages
   entitlements = attr.ib()  # Optional relative path to an entitlements file