feat(database): enable database multi-resource support (#159)

* feat(database): enable database multi-resource support

* refactor(database): fix property names

Author: jshcrowthe

src/database.ts

@@ -29,7 +29,7 @@ export function registerDatabase(instance: FirebaseNamespace) {
   // Register the Database Service with the 'firebase' namespace.
   const namespace = instance.INTERNAL.registerService(
     'database',
-    app => RepoManager.getInstance().databaseFromApp(app),
+    (app, unused, url) => RepoManager.getInstance().databaseFromApp(app, url),
     // firebase.database namespace properties
     {
       Reference,
@@ -39,7 +39,9 @@ export function registerDatabase(instance: FirebaseNamespace) {
       INTERNAL,
       ServerValue: Database.ServerValue,
       TEST_ACCESS
-    }
+    },
+    null,
+    true
   );
 
   if (isNodeSdk()) {

src/database/core/Repo.ts

@@ -84,7 +84,7 @@ export class Repo {
    * @param {!FirebaseApp} app
    */
   constructor(
-    private repoInfo_: RepoInfo,
+    public repoInfo_: RepoInfo,
     forceRestClient: boolean,
     public app: FirebaseApp
   ) {

src/database/core/RepoManager.ts

@@ -34,10 +34,12 @@ let _staticInstance: RepoManager;
  */
 export class RepoManager {
   /**
-   * @private {!Object.<string, !Repo>}
+   * @private {!Object.<string, Object<string, !fb.core.Repo>>}
    */
   private repos_: {
-    [name: string]: Repo;
+    [appName: string]: {
+      [dbUrl: string]: Repo;
+    };
   } = {};
 
   /**
@@ -55,14 +57,18 @@ export class RepoManager {
 
   // TODO(koss): Remove these functions unless used in tests?
   interrupt() {
-    for (const repo in this.repos_) {
-      this.repos_[repo].interrupt();
+    for (const appName in this.repos_) {
+      for (const dbUrl in this.repos_[appName]) {
+        this.repos_[appName][dbUrl].interrupt();
+      }
     }
   }
 
   resume() {
-    for (const repo in this.repos_) {
-      this.repos_[repo].resume();
+    for (const appName in this.repos_) {
+      for (const dbUrl in this.repos_[appName]) {
+        this.repos_[appName][dbUrl].resume();
+      }
     }
   }
 
@@ -72,8 +78,8 @@ export class RepoManager {
    * @param {!FirebaseApp} app
    * @return {!Database}
    */
-  databaseFromApp(app: FirebaseApp): Database {
-    const dbUrl: string = app.options[DATABASE_URL_OPTION];
+  databaseFromApp(app: FirebaseApp, url?: string): Database {
+    const dbUrl: string = url || app.options[DATABASE_URL_OPTION];
     if (dbUrl === undefined) {
       fatal(
         "Can't determine Firebase Database URL.  Be sure to include " +
@@ -104,12 +110,15 @@ export class RepoManager {
    * @param {!Repo} repo
    */
   deleteRepo(repo: Repo) {
+    const appRepos = safeGet(this.repos_, repo.app.name);
     // This should never happen...
-    if (safeGet(this.repos_, repo.app.name) !== repo) {
-      fatal('Database ' + repo.app.name + ' has already been deleted.');
+    if (!appRepos || safeGet(appRepos, repo.repoInfo_.toURLString()) !== repo) {
+      fatal(
+        `Database ${repo.app.name}(${repo.repoInfo_}) has already been deleted.`
+      );
     }
     repo.interrupt();
-    delete this.repos_[repo.app.name];
+    delete appRepos[repo.repoInfo_.toURLString()];
   }
 
   /**
@@ -121,12 +130,21 @@ export class RepoManager {
    * @return {!Repo} The Repo object for the specified server / repoName.
    */
   createRepo(repoInfo: RepoInfo, app: FirebaseApp): Repo {
-    let repo = safeGet(this.repos_, app.name);
+    let appRepos = safeGet(this.repos_, app.name);
+
+    if (!appRepos) {
+      appRepos = {};
+      this.repos_[app.name] = appRepos;
+    }
+
+    let repo = safeGet(appRepos, repoInfo.toURLString());
     if (repo) {
-      fatal('FIREBASE INTERNAL ERROR: Database initialized multiple times.');
+      fatal(
+        'Database initialized multiple times. Please make sure the format of the database URL matches with each database() call.'
+      );
     }
     repo = new Repo(repoInfo, this.useRestClient_, app);
-    this.repos_[app.name] = repo;
+    appRepos[repoInfo.toURLString()] = repo;
 
     return repo;
   }

tests/database/database.test.ts

@@ -45,6 +45,51 @@ describe('Database Tests', function() {
     }).to.throw(/don't call new Database/i);
   });
 
+  it('Can get database with custom URL', function() {
+    var db = defaultApp.database('http://foo.bar.com');
+    expect(db).to.be.ok;
+    // The URL is assumed to be secure if no port is specified.
+    expect(db.ref().toString()).to.equal('https://foo.bar.com/');
+  });
+
+  it('Can get database with custom URL and port', function() {
+    var db = defaultApp.database('http://foo.bar.com:80');
+    expect(db).to.be.ok;
+    expect(db.ref().toString()).to.equal('http://foo.bar.com:80/');
+  });
+
+  it('Can get database with https URL', function() {
+    var db = defaultApp.database('https://foo.bar.com');
+    expect(db).to.be.ok;
+    expect(db.ref().toString()).to.equal('https://foo.bar.com/');
+  });
+
+  it('Different instances for different URLs', function() {
+    var db1 = defaultApp.database('http://foo1.bar.com');
+    var db2 = defaultApp.database('http://foo2.bar.com');
+    expect(db1.ref().toString()).to.equal('https://foo1.bar.com/');
+    expect(db2.ref().toString()).to.equal('https://foo2.bar.com/');
+  });
+
+  it('Cannot use same URL twice', function() {
+    defaultApp.database('http://foo.bar.com');
+    expect(function() {
+      defaultApp.database('http://foo.bar.com/');
+    }).to.throw(/Database initialized multiple times/i);
+  });
+
+  it('Databases with invalid custom URLs', function() {
+    expect(function() {
+      defaultApp.database('not-a-url');
+    }).to.throw(/Cannot parse Firebase url/i);
+    expect(function() {
+      defaultApp.database('http://fblocal.com');
+    }).to.throw(/Cannot parse Firebase url/i);
+    expect(function() {
+      defaultApp.database('http://x.fblocal.com:9000/paths/are/bad');
+    }).to.throw(/Database URL must point to the root of a Firebase Database/i);
+  });
+
   it('Can get app', function() {
     const db = firebase.database();
     expect(db.app).to.not.be.undefined;