Merge master into release

Author: google-oss-bot

.github/workflows/test-all.yml

@@ -7,6 +7,10 @@ on:
 env:
   # make chromedriver detect installed Chrome version and download the corresponding driver
   DETECT_CHROMEDRIVER_VERSION: true
+  # The default behavior of chromedriver uses the older Chrome download URLs. We need to override
+  # the beahvior to use the new URLs.
+  CHROMEDRIVER_CDNURL: https://googlechromelabs.github.io/
+  CHROMEDRIVER_CDNBINARIESURL: https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/
   artifactRetentionDays: 14
 
 jobs:
@@ -17,14 +21,8 @@ jobs:
     # Install Chrome so the correct version of webdriver can be installed by chromedriver when
     # setting up the repo. This must be done to build and execute Auth properly.
     - name: install Chrome stable
-      # Pin Chrome version 114.0.5735.90-1 to avoid install failures like "No such object: chromedriver/LATEST_RELEASE_115.0.5790".
-      # The failure happens because https://chromedriver.chromium.org/downloads only goes up to version 114.
-      # TODO(b/297380444) Update script to install the latest Chrome and ChromeDriver.
       run: |
-        sudo apt-get update
-        sudo apt-get install wget
-        sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb
-        sudo apt-get install -f ./google-chrome-stable_114.0.5735.90-1_amd64.deb --allow-downgrades
+        npx @puppeteer/browsers install chrome@stable
     - uses: actions/checkout@v3
     - name: Set up Node (16)
       uses: actions/setup-node@v3
@@ -101,16 +99,11 @@ jobs:
     needs: build
     runs-on: ubuntu-latest
     steps:
-    # install Chrome so the correct version of webdriver can be installed by chromedriver when setting up the repo
-    - name: install Chrome stable
-      # Pin Chrome version 114.0.5735.90-1 to avoid install failures like "No such object: chromedriver/LATEST_RELEASE_115.0.5790".
-      # The failure happens because https://chromedriver.chromium.org/downloads only goes up to version 114.
-      # TODO(b/297380444) Update script to install the latest Chrome and ChromeDriver.
-      run: |
-        sudo apt-get update
-        sudo apt-get install wget
-        sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb
-        sudo apt-get install -f ./google-chrome-stable_114.0.5735.90-1_amd64.deb --allow-downgrades
+      # install Chrome first, so the correct version of webdriver can be installed by chromedriver
+      # when setting up the repo
+      - name: install Chrome stable
+        run: |
+          npx @puppeteer/browsers install chrome@stable
     - name: Download build archive
       uses: actions/download-artifact@v3
       with:

.github/workflows/test-changed-auth.yml

@@ -5,32 +5,31 @@ on: pull_request
 env:
   # make chromedriver detect installed Chrome version and download the corresponding driver
   DETECT_CHROMEDRIVER_VERSION: true
+  # The default behavior of chromedriver uses the older Chrome download URLs. We need to override
+  # the beahvior to use the new URLs.
+  CHROMEDRIVER_CDNURL: https://googlechromelabs.github.io/
+  CHROMEDRIVER_CDNBINARIESURL: https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/
 
 jobs:
   test-chrome:
     name: Test Auth on Chrome and Node If Changed
     runs-on: ubuntu-latest
 
     steps:
-      # install Chrome first, so the correct version of webdriver can be installed by chromedriver when setting up the repo
+      # install Chrome first, so the correct version of webdriver can be installed by chromedriver
+      # when setting up the repo
       - name: install Chrome stable
-        # Pin Chrome version 114.0.5735.90-1 to avoid install failures like "No such object: chromedriver/LATEST_RELEASE_115.0.5790".
-        # The failure happens because https://chromedriver.chromium.org/downloads only goes up to version 114.
-        # TODO(b/297380444) Update script to install the latest Chrome and ChromeDriver.
         run: |
-          sudo apt-get update
-          sudo apt-get install wget
-          sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb
-          sudo apt-get install -f ./google-chrome-stable_114.0.5735.90-1_amd64.deb --allow-downgrades
+          npx @puppeteer/browsers install chrome@stable
       - name: Checkout Repo
         uses: actions/checkout@master
         with:
           # This makes Actions fetch all Git history so run-changed script can diff properly.
           fetch-depth: 0
-      - name: Set up Node (14)
+      - name: Set up Node (16)
         uses: actions/setup-node@v3
         with:
-          node-version: 14.x
+          node-version: 16.x
       - name: Bump Node memory limit
         run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
       - name: Test setup and yarn install
@@ -49,27 +48,22 @@ jobs:
 
     runs-on: ubuntu-20.04
 
-    # Pin Chrome version 114.0.5735.90-1 to avoid install failures like "No such object: chromedriver/LATEST_RELEASE_115.0.5790".
-    # The failure happens because https://chromedriver.chromium.org/downloads only goes up to version 114.
-    # TODO(b/297380444) Update script to install the latest Chrome and ChromeDriver.
     steps:
       - name: install Firefox stable
         run: |
           sudo apt-get update
           sudo apt-get install firefox
           sudo apt-get install wget
-          sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb
-          sudo apt-get install -f ./google-chrome-stable_114.0.5735.90-1_amd64.deb --allow-downgrades
 
       - name: Checkout Repo
         uses: actions/checkout@master
         with:
           # This makes Actions fetch all Git history so run-changed script can diff properly.
           fetch-depth: 0
-      - name: Set up Node (14)
+      - name: Set up Node (16)
         uses: actions/setup-node@v3
         with:
-          node-version: 14.x
+          node-version: 16.x
       - name: Bump Node memory limit
         run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
       - name: Test setup and yarn install

.github/workflows/test-changed-fcm-integration.yml

@@ -22,10 +22,10 @@ jobs:
       with:
         # This makes Actions fetch all Git history so run-changed script can diff properly.
         fetch-depth: 0
-    - name: Set up Node (14)
+    - name: Set up Node (16)
       uses: actions/setup-node@v3
       with:
-        node-version: 14.x
+        node-version: 16.x
     - name: Bump Node memory limit
       run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
     - name: Test setup and yarn install

.github/workflows/test-changed-firestore-integration.yml

@@ -13,10 +13,10 @@ jobs:
       with:
         # This makes Actions fetch all Git history so run-changed script can diff properly.
         fetch-depth: 0
-    - name: Set up Node (14)
+    - name: Set up Node (16)
       uses: actions/setup-node@v3
       with:
-        node-version: 14.x
+        node-version: 16.x
     - name: install Chrome stable
       run: |
         sudo apt-get update

.github/workflows/test-changed-firestore.yml

@@ -19,10 +19,10 @@ jobs:
         with:
           # This makes Actions fetch all Git history so run-changed script can diff properly.
           fetch-depth: 0
-      - name: Set up Node (14)
+      - name: Set up Node (16)
         uses: actions/setup-node@v3
         with:
-          node-version: 14.x
+          node-version: 16.x
       - name: install Chrome stable
         run: |
           sudo apt-get update
@@ -68,10 +68,10 @@ jobs:
     needs: build
     if: ${{ needs.build.outputs.changed == 'true'}}
     steps:
-      - name: Set up Node (14)
+      - name: Set up Node (16)
         uses: actions/setup-node@v3
         with:
-          node-version: 14.x
+          node-version: 16.x
       - name: install Chrome stable
         run: |
           sudo apt-get update
@@ -98,10 +98,10 @@ jobs:
     needs: build
     if: ${{ needs.build.outputs.changed == 'true'}}
     steps:
-      - name: Set up Node (14)
+      - name: Set up Node (16)
         uses: actions/setup-node@v3
         with:
-          node-version: 14.x
+          node-version: 16.x
       - name: install Chrome stable
         run: |
           sudo apt-get update
@@ -118,6 +118,8 @@ jobs:
         run: cp config/ci.config.json config/project.json
       - name: Run tests
         run: cd packages/firestore && yarn run ${{ matrix.test-name }}
+        env:
+          EXPERIMENTAL_MODE: true
 
   compat-test-firefox:
     name: Test Firestore Compatible on Firefox
@@ -132,10 +134,10 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install firefox
-      - name: Set up Node (14)
+      - name: Set up Node (16)
         uses: actions/setup-node@v3
         with:
-          node-version: 14.x
+          node-version: 16.x
       - name: Download build archive
         uses: actions/download-artifact@v3
         with:
@@ -173,10 +175,10 @@ jobs:
           name: build.tar.gz
       - name: Unzip build artifact
         run: tar xf build.tar.gz
-      - name: Set up Node (14)
+      - name: Set up Node (16)
         uses: actions/setup-node@v3
         with:
-          node-version: 14.x
+          node-version: 16.x
       - name: Bump Node memory limit
         run: echo "NODE_OPTIONS=--max_old_space_size=4096" >> $GITHUB_ENV
       - name: Test setup and yarn install
@@ -185,6 +187,7 @@ jobs:
         run: cd packages/firestore && xvfb-run yarn run ${{ matrix.test-name }}
         env:
           BROWSERS: 'Firefox'
+          EXPERIMENTAL_MODE: true
 
   # A job that fails if any required job in the test matrix fails,
   # to be used as a required check for merging.

.github/workflows/test-changed.yml

@@ -13,10 +13,10 @@ jobs:
         with:
           # This makes Actions fetch all Git history so run-changed script can diff properly.
           fetch-depth: 0
-      - name: Set up Node (14)
+      - name: Set up Node (16)
         uses: actions/setup-node@v3
         with:
-          node-version: 14.x
+          node-version: 16.x
       - name: install Chrome stable
         run: |
           sudo apt-get update
@@ -44,10 +44,10 @@ jobs:
         uses: actions/checkout@master
         with:
           fetch-depth: 0
-      - name: Set up Node (14)
+      - name: Set up Node (16)
         uses: actions/setup-node@v3
         with:
-          node-version: 14.x
+          node-version: 16.x
       - name: install Firefox stable
         run: |
           sudo apt-get update

.github/workflows/test-firebase-integration.yml

@@ -13,10 +13,10 @@ jobs:
       with:
         # This makes Actions fetch all Git history so run-changed script can diff properly.
         fetch-depth: 0
-    - name: Set up Node (14)
+    - name: Set up Node (16)
       uses: actions/setup-node@v3
       with:
-        node-version: 14.x
+        node-version: 16.x
     - name: install Chrome stable
       run: |
         sudo apt-get update

integration/messaging/package.json

@@ -11,7 +11,7 @@
   "devDependencies": {
     "firebase": "10.4.0",
     "chai": "4.3.7",
-    "chromedriver": "98.0.1",
+    "chromedriver": "114.0.2",
     "express": "4.18.2",
     "geckodriver": "2.0.4",
     "mocha": "9.2.2",

packages/analytics-compat/package.json

@@ -45,7 +45,7 @@
     "build:deps": "lerna run --scope @firebase/analytics-compat --include-dependencies build",
     "build:release": "yarn build && yarn add-compat-overloads",
     "dev": "rollup -c -w",
-    "test": "run-p lint test:browser",
+    "test": "run-p --npm-path npm lint test:browser",
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test:browser",
     "test:browser": "karma start --single-run",
     "test:browser:debug": "karma start --browsers=Chrome --auto-watch",

packages/analytics/package.json

@@ -26,8 +26,8 @@
     "build:release": "yarn build && yarn typings:public",
     "build:deps": "lerna run --scope @firebase/analytics --include-dependencies build",
     "dev": "rollup -c -w",
-    "test": "run-p lint test:all",
-    "test:all": "run-p test:browser test:integration",
+    "test": "run-p --npm-path npm lint test:all",
+    "test:all": "run-p --npm-path npm test:browser test:integration",
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
     "test:browser": "karma start --single-run --nocache",
     "test:integration": "karma start ./karma.integration.conf.js --single-run --nocache",