Fix issue with IDP sign in error handling (#4394)

* Fix issue with IDP sign in error handling

* Formatting

Author: sam-gc

packages-exp/auth-exp/src/api/authentication/idp.ts

@@ -25,6 +25,7 @@ export interface SignInWithIdpRequest {
   sessionId?: string;
   tenantId?: string;
   returnSecureToken: boolean;
+  returnIdpCredential?: boolean;
   idToken?: IdToken;
   autoCreate?: boolean;
   pendingToken?: string;

packages-exp/auth-exp/src/api/index.test.ts

@@ -120,6 +120,27 @@ describe('api/_performApiRequest', () => {
       expect(mock.calls[0].request).to.eql(request);
     });
 
+    it('should translate server success with errorMessage into auth error', async () => {
+      const response = {
+        errorMessage: ServerError.FEDERATED_USER_ID_ALREADY_LINKED,
+        idToken: 'foo-bar'
+      };
+      const mock = mockEndpoint(Endpoint.SIGN_IN_WITH_IDP, response, 200);
+      const promise = _performApiRequest<typeof request, typeof serverResponse>(
+        auth,
+        HttpMethod.POST,
+        Endpoint.SIGN_IN_WITH_IDP,
+        request
+      );
+      await expect(promise)
+        .to.be.rejectedWith(FirebaseError, 'auth/credential-already-in-use')
+        .eventually.with.deep.property('customData', {
+          appName: 'test-app',
+          _tokenResponse: response
+        });
+      expect(mock.calls[0].request).to.eql(request);
+    });
+
     it('should translate complex server errors to auth errors', async () => {
       const mock = mockEndpoint(
         Endpoint.SIGN_UP,

packages-exp/auth-exp/src/api/index.ts

@@ -132,10 +132,11 @@ export async function _performFetchWithErrorHandling<V>(
       throw makeTaggedError(auth, AuthErrorCode.NEED_CONFIRMATION, json);
     }
 
-    if (response.ok) {
+    if (response.ok && !('errorMessage' in json)) {
       return json;
     } else {
-      const serverErrorCode = json.error.message.split(' : ')[0] as ServerError;
+      const errorMessage = response.ok ? json.errorMessage : json.error.message;
+      const serverErrorCode = errorMessage.split(' : ')[0] as ServerError;
       if (serverErrorCode === ServerError.FEDERATED_USER_ID_ALREADY_LINKED) {
         throw makeTaggedError(
           auth,

packages-exp/auth-exp/src/core/strategies/idp.test.ts

@@ -82,7 +82,8 @@ describe('core/strategies/idb', () => {
         postBody: 'post-body',
         tenantId: 'tenant-id',
         pendingToken: 'pending-token',
-        returnSecureToken: true
+        returnSecureToken: true,
+        returnIdpCredential: true
       });
     });
 
@@ -136,7 +137,8 @@ describe('core/strategies/idb', () => {
         postBody: 'post-body',
         tenantId: 'tenant-id',
         pendingToken: 'pending-token',
-        returnSecureToken: true
+        returnSecureToken: true,
+        returnIdpCredential: true
       });
     });
 
@@ -193,6 +195,7 @@ describe('core/strategies/idb', () => {
         tenantId: 'tenant-id',
         pendingToken: 'pending-token',
         returnSecureToken: true,
+        returnIdpCredential: true,
         idToken: idTokenBeforeLink
       });
     });

packages-exp/auth-exp/src/core/strategies/idp.ts

@@ -71,7 +71,8 @@ class IdpCredential extends AuthCredential {
       postBody: this.params.postBody || null,
       tenantId: this.params.tenantId,
       pendingToken: this.params.pendingToken,
-      returnSecureToken: true
+      returnSecureToken: true,
+      returnIdpCredential: true
     };
 
     if (idToken) {