Fix (silently) broken Auth-exp tests (#4378)

* Fix silently broken auth tests

* Fix test issues

* Formatting

* PR feedback

Author: sam-gc

packages-exp/auth-exp/src/platform_browser/messagechannel/sender.test.ts

@@ -29,14 +29,15 @@ import {
   _Status,
   _TimeoutDuration
 } from '.';
-import { delay } from '../../../test/helpers/delay';
 import { FakeServiceWorker } from '../../../test/helpers/fake_service_worker';
 import { stubTimeouts, TimerMap } from '../../../test/helpers/timeout_stub';
 import { Sender } from './sender';
 
 use(sinonChai);
 use(chaiAsPromised);
 
+const oldSetTimeout = setTimeout;
+
 describe('platform_browser/messagechannel/sender', () => {
   describe('_send', () => {
     let sender: Sender;
@@ -88,7 +89,8 @@ describe('platform_browser/messagechannel/sender', () => {
 
     it('should timeout if it doesnt see an ACK', async () => {
       serviceWorker.addEventListener('message', (_event: Event) => {
-        delay(() => {
+        // eslint-disable-next-line @typescript-eslint/no-floating-promises
+        Promise.resolve().then(() => {
           pendingTimeouts[_TimeoutDuration.ACK]();
         });
       });
@@ -109,7 +111,8 @@ describe('platform_browser/messagechannel/sender', () => {
         }
       ];
       serviceWorker.addEventListener('message', (event: Event) => {
-        delay(() => {
+        // eslint-disable-next-line @typescript-eslint/no-floating-promises
+        Promise.resolve().then(() => {
           pendingTimeouts[_TimeoutDuration.ACK]();
         });
         const messageEvent = event as MessageEvent<
@@ -138,6 +141,9 @@ describe('platform_browser/messagechannel/sender', () => {
 
     it('it should timeout if it gets an ACK but not a DONE', async () => {
       serviceWorker.addEventListener('message', (event: Event) => {
+        oldSetTimeout(() => {
+          pendingTimeouts[_TimeoutDuration.COMPLETION]();
+        }, 5);
         const messageEvent = event as MessageEvent<
           SenderMessageEvent<PingRequest>
         >;
@@ -147,9 +153,6 @@ describe('platform_browser/messagechannel/sender', () => {
           eventType: messageEvent.data.eventType,
           response: null
         } as ReceiverMessageEvent<_PingResponse>);
-        delay(() => {
-          pendingTimeouts[_TimeoutDuration.COMPLETION]();
-        });
       });
       await expect(
         sender._send<_PingResponse, PingRequest>(

packages-exp/auth-exp/src/platform_browser/popup_redirect.test.ts

@@ -55,9 +55,7 @@ describe('platform_browser/popup_redirect', () => {
 
   beforeEach(async () => {
     auth = await testAuth();
-    resolver = new (browserPopupRedirectResolver as SingletonInstantiator<
-      PopupRedirectResolver
-    >)();
+    resolver = new (browserPopupRedirectResolver as SingletonInstantiator<PopupRedirectResolver>)();
 
     sinon.stub(validateOrigin, '_validateOrigin').returns(Promise.resolve());
     iframeSendStub = sinon.stub();
@@ -74,6 +72,12 @@ describe('platform_browser/popup_redirect', () => {
           })
       } as unknown) as gapi.iframes.Context)
     );
+
+    sinon.stub(authWindow._window(), 'gapi').value({
+      iframes: {
+        CROSS_ORIGIN_IFRAMES_FILTER: 'cross-origin-iframes-filter'
+      }
+    });
   });
 
   afterEach(() => {
@@ -113,13 +117,11 @@ describe('platform_browser/popup_redirect', () => {
       );
     });
 
-    it('throws an error if authDomain is unspecified', async () => {
-      delete auth.config.authDomain;
+    it('validates the origin', async () => {
       await resolver._initialize(auth);
 
-      await expect(
-        resolver._openPopup(auth, provider, event)
-      ).to.be.rejectedWith(FirebaseError, 'auth/auth-domain-config-required');
+      await resolver._openPopup(auth, provider, event);
+      expect(validateOrigin._validateOrigin).to.have.been.calledWith(auth);
     });
 
     it('throws an error if apiKey is unspecified', async () => {
@@ -312,7 +314,7 @@ describe('platform_browser/popup_redirect', () => {
       expect(args[1]).to.eql({
         type: 'webStorageSupport'
       });
-      expect(args[3]).to.eq(gapi.iframes.CROSS_ORIGIN_IFRAMES_FILTER);
+      expect(args[3]).to.eq('cross-origin-iframes-filter');
     });
 
     it('passes through true value from the response to the callback', done => {

packages-exp/auth-exp/src/platform_browser/strategies/phone.test.ts

@@ -418,13 +418,15 @@ describe('platform_browser/strategies/phone', () => {
     let reloadMock: fetch.Route;
     let signInMock: fetch.Route;
     let credential: PhoneAuthCredential;
+    let idToken: string;
 
     beforeEach(() => {
+      idToken = makeJWT({ exp: '200', iat: '100' });
       reloadMock = mockEndpoint(Endpoint.GET_ACCOUNT_INFO, {
         users: [{ uid: 'uid' }]
       });
       signInMock = mockEndpoint(Endpoint.SIGN_IN_WITH_PHONE_NUMBER, {
-        idToken: 'new-access-token',
+        idToken,
         refreshToken: 'refresh-token'
       });
       credential = PhoneAuthCredential._fromVerification(
@@ -447,7 +449,7 @@ describe('platform_browser/strategies/phone', () => {
     it('should update the access token', async () => {
       await updatePhoneNumber(user, credential);
       const idToken = await user.getIdToken();
-      expect(idToken).to.eq('new-access-token');
+      expect(idToken).to.eq(idToken);
     });
 
     it('should reload the user', async () => {