Skip to content

Commit 20c7bdb

Browse files
committed
Merge branch 'feat/pipelines' into markduckworth/g3-import-firestore-globals
2 parents 3f8d12e + f4c72a7 commit 20c7bdb

File tree

81 files changed

+2099
-927
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

81 files changed

+2099
-927
lines changed

.changeset/angry-apples-think.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

.changeset/dull-ligers-bow.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

.changeset/fast-rocks-sing.md

Lines changed: 0 additions & 6 deletions
This file was deleted.

.changeset/metal-lies-compete.md

Lines changed: 0 additions & 6 deletions
This file was deleted.

.changeset/rare-hats-know.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

.changeset/smooth-parrots-speak.md

Lines changed: 0 additions & 6 deletions
This file was deleted.

.changeset/spotty-shirts-design.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@firebase/data-connect": patch
3+
---
4+
5+
Fixed issue where onComplete wasn't triggering when the user calls `unsubscribe` on a subscription.

common/api-review/data-connect.api.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -109,16 +109,6 @@ export interface DataConnectResult<Data, Variables> extends OpResult<Data> {
109109
ref: OperationRef<Data, Variables>;
110110
}
111111

112-
// @public
113-
export interface DataConnectSubscription<Data, Variables> {
114-
// (undocumented)
115-
errCallback?: (e?: DataConnectError) => void;
116-
// (undocumented)
117-
unsubscribe: () => void;
118-
// (undocumented)
119-
userCallback: OnResultSubscription<Data, Variables>;
120-
}
121-
122112
// @public (undocumented)
123113
export type DataSource = typeof SOURCE_CACHE | typeof SOURCE_SERVER;
124114

0 commit comments

Comments
 (0)