fix(app): Allow Object.prototype member names as app names (#70)

Author: jsayol

src/app/firebase_app.ts

@@ -217,6 +217,10 @@ export interface FirebaseNamespace {
   }
 }
 
+const contains = function(obj, key) {
+  return Object.prototype.hasOwnProperty.call(obj, key);
+};
+
 let LocalPromise = local.Promise as typeof Promise;
 
 const DEFAULT_ENTRY_NAME = '[DEFAULT]';
@@ -438,11 +442,10 @@ export function createFirebaseNamespace(): FirebaseNamespace {
    */
   function app(name?: string): FirebaseApp {
     name = name || DEFAULT_ENTRY_NAME;
-    let result = apps_[name];
-    if (result === undefined) {
+    if (!contains(apps_, name)) {
       error('no-app', {'name': name});
     }
-    return result;
+    return apps_[name];
   }
 
   patchProperty(app, 'App', FirebaseAppImpl);
@@ -458,7 +461,7 @@ export function createFirebaseNamespace(): FirebaseNamespace {
         error('bad-app-name', {'name': name + ''});
       }
     }
-    if (apps_[name!] !== undefined) {
+    if (contains(apps_, name) ) {
       error('duplicate-app', {'name': name});
     }
 

tests/app/unit/firebase_app.test.ts

@@ -143,6 +143,19 @@ describe("Firebase App Class", () => {
       });
   });
 
+  it("OK to use Object.prototype member names as app name.", () => {
+    let app = firebase.initializeApp({}, 'toString');
+    assert.equal(firebase.apps.length, 1);
+    assert.equal(app.name, 'toString');
+    assert.strictEqual(firebase.app('toString'), app);
+  });
+
+  it("Error to get uninitialized app using Object.prototype member name.", () => {
+    assert.throws(() => {
+      firebase.app('toString');
+    }, /'toString'.*created/i);
+  });
+
   it("Only calls createService on first use (per app).", () => {
     let registrations = 0;
     firebase.INTERNAL.registerService('test', (app: FirebaseApp) => {