[Swift 6] Sessions Swift 6 changes (#14575)

Author: ncooke3

FirebaseSessions/Sources/FirebaseSessions.swift

@@ -149,13 +149,14 @@ private enum GoogleDataTransportConfig {
 
     super.init()
 
-    for subscriberName in SessionsDependencies.dependencies {
+    let dependencies = SessionsDependencies.dependencies
+    for subscriberName in dependencies {
       subscriberPromises[subscriberName] = Promise<Void>.pending()
     }
 
     Logger
       .logDebug(
-        "Version \(FirebaseVersion()). Expecting subscriptions from: \(SessionsDependencies.dependencies)"
+        "Version \(FirebaseVersion()). Expecting subscriptions from: \(dependencies)"
       )
 
     self.initiator.beginListening {

FirebaseSessions/Sources/Public/SessionsDependencies.swift

@@ -15,18 +15,62 @@
 
 import Foundation
 
-// Sessions Dependencies determines when a dependent SDK is
-// installed in the app. The Sessions SDK uses this to figure
-// out which dependencies to wait for to getting the data
-// collection state.
-//
-// This is important because the Sessions SDK starts up before
-// dependent SDKs
+private final class AtomicBox<T> {
+  private var _value: T
+  private let lock = NSLock()
+
+  init(_ value: T) {
+    _value = value
+  }
+
+  func value() -> T {
+    lock.withLock {
+      _value
+    }
+  }
+
+  @discardableResult func withLock(_ body: (_ value: inout T) -> Void) -> T {
+    lock.withLock {
+      body(&_value)
+      return _value
+    }
+  }
+}
+
+/// Sessions Dependencies determines when a dependent SDK is
+/// installed in the app. The Sessions SDK uses this to figure
+/// out which dependencies to wait for to getting the data
+/// collection state.
+///
+/// This is important because the Sessions SDK starts up before
+/// dependent SDKs
 @objc(FIRSessionsDependencies)
 public class SessionsDependencies: NSObject {
-  static var dependencies: Set<SessionsSubscriberName> = .init()
+  #if compiler(>=6)
+    private nonisolated(unsafe) static let _dependencies: AtomicBox<Set<SessionsSubscriberName>> =
+      AtomicBox(
+        Set()
+      )
+  #else
+    private static let _dependencies: AtomicBox<Set<SessionsSubscriberName>> = AtomicBox(
+      Set()
+    )
+  #endif
+
+  static var dependencies: Set<SessionsSubscriberName> {
+    _dependencies.value()
+  }
 
   @objc public static func addDependency(name: SessionsSubscriberName) {
-    SessionsDependencies.dependencies.insert(name)
+    _dependencies.withLock { dependencies in
+      dependencies.insert(name)
+    }
+  }
+
+  /// For testing only.
+  static func removeAll() {
+    _dependencies.withLock { dependencies in
+      dependencies.removeAll()
+    }
   }
 }

FirebaseSessions/Tests/Unit/Library/FirebaseSessionsTestsBase.swift

@@ -77,7 +77,7 @@ class FirebaseSessionsTestsBase: XCTestCase {
                       postLogEvent: @escaping (Result<Void, FirebaseSessionsError>,
                                                [SessionsSubscriber]) -> Void) {
     // This class is static, so we need to clear global state
-    SessionsDependencies.dependencies.removeAll()
+    SessionsDependencies.removeAll()
 
     for subscriberSDK in subscriberSDKs {
       SessionsDependencies.addDependency(name: subscriberSDK.sessionsSubscriberName)