Skip to content

Commit 219add6

Browse files
committed
solve merge error
1 parent af33109 commit 219add6

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

Firestore/Swift/Source/ExpressionImplementation.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -727,7 +727,7 @@ public extension Expression {
727727
}
728728

729729
func byteLength() -> FunctionExpression {
730-
return FunctionExpression("byte_length", [self])
730+
return FunctionExpression(functionName: "byte_length", args: [self])
731731
}
732732

733733
func substring(position: Int, length: Int? = nil) -> FunctionExpression {

Firestore/Swift/Source/SwiftAPI/Pipeline/Expressions/Expression.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,6 @@ public protocol Expression: Sendable {
465465
/// than the given expression.
466466
///
467467
/// - Parameter other: The expression to compare against.
468-
/// - Returns: A `BooleanExpression` that can be used in `where` clauses.
469468
/// - Returns: A `BooleanExpression` that can be used in a where stage, together with other
470469
/// boolean expressions.
471470
func greaterThan(_ other: Expression) -> BooleanExpression
@@ -740,7 +739,7 @@ public protocol Expression: Sendable {
740739
/// ```
741740
///
742741
/// - Parameter pattern: The literal string regular expression to use for the search.
743-
/// - Returns: A new `BooleanExpr` representing the "regex_contains" comparison.
742+
/// - Returns: A new `BooleanExpression` representing the "regex_contains" comparison.
744743
func regexContains(_ pattern: String) -> BooleanExpression
745744

746745
/// Creates an expression that checks if a string (from `self`) contains a specified regular

Firestore/Swift/Tests/Integration/PipelineTests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2755,7 +2755,7 @@ class PipelineIntegrationTests: FSTIntegrationTestCase {
27552755
.limit(1)
27562756
.select(
27572757
[
2758-
FunctionExpression("add", [Field("rating"), Constant(1)]).as(
2758+
FunctionExpression(functionName: "add", args: [Field("rating"), Constant(1)]).as(
27592759
"rating"
27602760
),
27612761
]
@@ -2807,8 +2807,8 @@ class PipelineIntegrationTests: FSTIntegrationTestCase {
28072807
let pipeline = db.pipeline()
28082808
.collection(collRef.path)
28092809
.where(BooleanExpression(
2810-
"array_contains_any",
2811-
[Field("tags"), ArrayExpression(["politics"])]
2810+
functionName: "array_contains_any",
2811+
args: [Field("tags"), ArrayExpression(["politics"])]
28122812
))
28132813
.select([Field("title")])
28142814

0 commit comments

Comments
 (0)