[Xcode 15] Spaces are now valid in URL strings (#11407)

Author: paulb777

FirebaseMLModelDownloader/Tests/Unit/ModelDownloaderUnitTests.swift

@@ -241,12 +241,10 @@
 
     /// Test how URL conversion behaves if there are spaces in the path.
     func testURLConversion() {
-      /// Spaces in the string only convert to URL when using URL(fileURLWithPath: ).
       let fakeURLWithSpace = URL(string: "file:///fakeDir1/fake%20Dir2/fakeFile")!
 
       XCTAssertEqual(fakeURLWithSpace, URL(string: fakeURLWithSpace.absoluteString))
       XCTAssertEqual(fakeURLWithSpace, URL(fileURLWithPath: fakeURLWithSpace.path))
-      XCTAssertNil(URL(string: fakeURLWithSpace.path))
 
       /// Strings without spaces should work fine either way.
       let fakeURLWithoutSpace = URL(string: "fakeDir1/fakeDir2/fakeFile")!

FirebaseMessaging/Tests/UnitTests/FIRMessagingLinkHandlingTest.m

@@ -82,14 +82,6 @@ - (void)testNonStringLinkInMessage {
   XCTAssertNil(url);
 }
 
-- (void)testInvalidURLStringLinkInMessage {
-  NSMutableDictionary *notification =
-      [FIRMessagingTestNotificationUtilities createBasicNotificationWithUniqueMessageID];
-  notification[kFIRMessagingMessageLinkKey] = @"This is not a valid url string";
-  NSURL *url = [_messaging linkURLFromMessage:notification];
-  XCTAssertNil(url);
-}
-
 - (void)testValidURLStringLinkInMessage {
   NSMutableDictionary *notification =
       [FIRMessagingTestNotificationUtilities createBasicNotificationWithUniqueMessageID];