Adds npm lint command and updates lint options (#467)

* adding lint command and modifying lint options

* one additional format fix

* order deps in package.json, remove unnecessary [] from tslint

* Lint spec/* files (#468)

* adding lint command and modifying lint options

* one additional format fix

* order deps in package.json, remove unnecessary [] from tslint

Author: thechenky

integration_test/functions/src/index.ts

@@ -52,7 +52,9 @@ function callScheduleTrigger(functionName: string, region: string) {
       {
         method: 'POST',
         host: 'cloudscheduler.googleapis.com',
-        path: `projects/${firebaseConfig.projectId}/locations/us-central1/jobs/firebase-schedule-${functionName}-${region}:run`,
+        path: `projects/${
+          firebaseConfig.projectId
+        }/locations/us-central1/jobs/firebase-schedule-${functionName}-${region}:run`,
         headers: {
           'Content-Type': 'application/json',
         },
@@ -197,7 +199,9 @@ export const integrationTests: any = functions
         resp
           .status(500)
           .send(
-            `FAIL - details at https://${process.env.GCLOUD_PROJECT}.firebaseio.com/testRuns/${testId}`
+            `FAIL - details at https://${
+              process.env.GCLOUD_PROJECT
+            }.firebaseio.com/testRuns/${testId}`
           );
       });
   });

package.json

@@ -25,6 +25,7 @@
     "build:release": "npm install --production && npm install typescript firebase-admin && tsc -p tsconfig.release.json",
     "build": "tsc -p tsconfig.release.json",
     "format": "prettier --write '**/*.ts'",
+    "lint": "tslint --project tsconfig.json --config tslint.json",
     "posttest": "npm run format",
     "test": "mocha -r ts-node/register ./spec/index.spec.ts"
   },
@@ -56,6 +57,9 @@
     "prettier": "^1.17.1",
     "sinon": "^7.3.2",
     "ts-node": "^8.2.0",
+    "tslint": "^5.17.0",
+    "tslint-no-unused-expression-chai": "^0.1.4",
+    "tslint-plugin-prettier": "^2.0.0",
     "typescript": "^3.5.1"
   },
   "peerDependencies": {

tslint.json

@@ -1,13 +1,15 @@
 {
-  "extends": "tslint:recommended",
+  "defaultSeverity": "warning",
+  "extends": ["tslint:recommended", "tslint-no-unused-expression-chai"],
   "rules": {
     "quotemark": [true, "single", "avoid-escape"],
-    "interface-name": [false],
+    "interface-name": false,
     "variable-name": [true, "check-format", "allow-leading-underscore"],
     "object-literal-sort-keys": false,
-    "whitespace": [true],
-    "member-access": [false],
-    "no-console": [false],
-    "no-namespace": [false]
+    "whitespace": true,
+    "member-access": false,
+    "no-console": false,
+    "no-namespace": false,
+    "trailing-comma": [true, { "functions": "never" }]
   }
 }