Include all TypeScript files in development configuration (#512)

* Include all TypeScript files in development configuration

* Autofix TSLint issues

* Reformat

Author: merlinnot

integration_test/functions/src/auth-tests.ts

@@ -1,10 +1,10 @@
-import * as functions from 'firebase-functions';
-import { TestSuite, expectEq } from './testing';
 import * as admin from 'firebase-admin';
+import * as functions from 'firebase-functions';
+import { expectEq, TestSuite } from './testing';
 import UserMetadata = admin.auth.UserRecord;
 
 export const createUserTests: any = functions.auth.user().onCreate((u, c) => {
-  let testId: string = u.displayName;
+  const testId: string = u.displayName;
   console.log(`testId is ${testId}`);
 
   return new TestSuite<UserMetadata>('auth user onCreate')
@@ -38,7 +38,7 @@ export const createUserTests: any = functions.auth.user().onCreate((u, c) => {
 });
 
 export const deleteUserTests: any = functions.auth.user().onDelete((u, c) => {
-  let testId: string = u.displayName;
+  const testId: string = u.displayName;
   console.log(`testId is ${testId}`);
 
   return new TestSuite<UserMetadata>('auth user onDelete')

integration_test/functions/src/database-tests.ts

@@ -1,6 +1,6 @@
-import * as functions from 'firebase-functions';
-import { TestSuite, expectEq, expectMatches } from './testing';
 import * as admin from 'firebase-admin';
+import * as functions from 'firebase-functions';
+import { expectEq, expectMatches, TestSuite } from './testing';
 import DataSnapshot = admin.database.DataSnapshot;
 
 const testIdFieldName = 'testId';

integration_test/functions/src/firestore-tests.ts

@@ -1,6 +1,6 @@
-import * as functions from 'firebase-functions';
-import { TestSuite, expectEq, expectDeepEq } from './testing';
 import * as admin from 'firebase-admin';
+import * as functions from 'firebase-functions';
+import { expectDeepEq, expectEq, TestSuite } from './testing';
 import DocumentSnapshot = admin.firestore.DocumentSnapshot;
 
 const testIdFieldName = 'documentId';

integration_test/functions/src/https-tests.ts

@@ -1,6 +1,6 @@
 import * as functions from 'firebase-functions';
 import * as _ from 'lodash';
-import { TestSuite, expectEq } from './testing';
+import { expectEq, TestSuite } from './testing';
 
 export const callableTests: any = functions.https.onCall((d) => {
   return new TestSuite('https onCall')

integration_test/functions/src/index.ts

@@ -1,11 +1,8 @@
-import * as functions from 'firebase-functions';
-import * as https from 'https';
-import * as admin from 'firebase-admin';
 import { Request, Response } from 'express';
+import * as admin from 'firebase-admin';
+import * as functions from 'firebase-functions';
 import * as fs from 'fs';
-
-import * as PubSub from '@google-cloud/pubsub';
-const pubsub = PubSub();
+import * as https from 'https';
 
 export * from './pubsub-tests';
 export * from './database-tests';
@@ -82,7 +79,7 @@ export const integrationTests: any = functions
       .split('.')
       .slice(1)
       .join('.');
-    let pubsub: any = require('@google-cloud/pubsub')();
+    const pubsub: any = require('@google-cloud/pubsub')();
     const testId = admin
       .database()
       .ref()
@@ -155,7 +152,7 @@ export const integrationTests: any = functions
       .then(() => {
         // On test completion, check that all tests pass and reply "PASS", or provide further details.
         console.log('Waiting for all tests to report they pass...');
-        let ref = admin.database().ref(`testRuns/${testId}`);
+        const ref = admin.database().ref(`testRuns/${testId}`);
         return new Promise((resolve, reject) => {
           let testsExecuted = 0;
           ref.on('child_added', (snapshot) => {

integration_test/functions/src/pubsub-tests.ts

@@ -1,6 +1,6 @@
-import * as functions from 'firebase-functions';
 import * as admin from 'firebase-admin';
-import { TestSuite, expectEq, evaluate, success } from './testing';
+import * as functions from 'firebase-functions';
+import { evaluate, expectEq, success, TestSuite } from './testing';
 import PubsubMessage = functions.pubsub.Message;
 
 // TODO(inlined) use multiple queues to run inline.
@@ -64,7 +64,7 @@ export const schedule: any = functions.pubsub
   // For the test, the job is triggered by the jobs:run api
   .onRun((context) => {
     let testId;
-    let db = admin.database();
+    const db = admin.database();
     return new Promise(async (resolve, reject) => {
       await db
         .ref('testRuns')

integration_test/functions/src/remoteConfig-tests.ts

@@ -1,5 +1,5 @@
 import * as functions from 'firebase-functions';
-import { TestSuite, expectEq } from './testing';
+import { expectEq, TestSuite } from './testing';
 import TemplateVersion = functions.remoteConfig.TemplateVersion;
 
 export const remoteConfigTests: any = functions.remoteConfig.onUpdate(

integration_test/functions/src/storage-tests.ts

@@ -1,7 +1,6 @@
 import * as functions from 'firebase-functions';
-import { TestSuite, expectEq, expectDeepEq } from './testing';
+import { expectEq, TestSuite } from './testing';
 import ObjectMetadata = functions.storage.ObjectMetadata;
-const testIdFieldName = 'documentId';
 
 export const storageTests: any = functions
   .runWith({

integration_test/functions/src/testing.ts

@@ -1,9 +1,11 @@
 import * as firebase from 'firebase-admin';
-import * as _ from 'lodash';
 import { EventContext } from 'firebase-functions';
+import * as _ from 'lodash';
 
 export type TestCase<T> = (data: T, context?: EventContext) => any;
-export type TestCaseMap<T> = { [key: string]: TestCase<T> };
+export interface TestCaseMap<T> {
+  [key: string]: TestCase<T>;
+}
 
 export class TestSuite<T> {
   private name: string;
@@ -20,8 +22,8 @@ export class TestSuite<T> {
   }
 
   run(testId: string, data: T, context?: EventContext): Promise<any> {
-    let running: Array<Promise<any>> = [];
-    for (let testName in this.tests) {
+    const running: Array<Promise<any>> = [];
+    for (const testName in this.tests) {
       if (!this.tests.hasOwnProperty(testName)) {
         continue;
       }
@@ -36,7 +38,7 @@ export class TestSuite<T> {
           },
           (error) => {
             console.error(`Failed: ${testName}`, error);
-            return { name: testName, passed: 0, error: error };
+            return { name: testName, passed: 0, error };
           }
         );
       running.push(run);

tsconfig.json

@@ -4,5 +4,5 @@
     "sourceMap": true
   },
   "extends": "./tsconfig.release.json",
-  "include": ["./src/**/*.ts", "./spec/**/*.ts"]
+  "include": ["**/*.ts"]
 }