Skip to content

Commit c4f63c7

Browse files
TheIronDevtaeold
andauthored
Update types for AlertPayloads (#1087)
* Update types for AlertPayloads This commit updates the typing for the AlertPayloads. There was a discrepency between the type definitions and what prod was returning. * From: `com.google.firebase.firebasealerts.*` * To: `type.googleapis.com/google.events.firebase.firebasealerts.v1.*` Co-authored-by: Daniel Lee <taeold@gmail.com>
1 parent c91fd9b commit c4f63c7

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/v2/providers/alerts/billing.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import * as options from '../../options';
77
* Payload is wrapped inside a FirebaseAlertData object.
88
*/
99
export interface PlanUpdatePayload {
10-
['@type']: 'com.google.firebase.firebasealerts.PlanUpdatePayload';
10+
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.BillingPlanUpdatePayload';
1111
billingPlan: string;
1212
principalEmail: string;
1313
}
@@ -17,7 +17,7 @@ export interface PlanUpdatePayload {
1717
* Payload is wrapped inside a FirebaseAlertData object.
1818
*/
1919
export interface PlanAutomatedUpdatePayload {
20-
['@type']: 'com.google.firebase.firebasealerts.PlanAutomatedUpdatePayload';
20+
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.BillingPlanAutomatedUpdatePayload';
2121
billingPlan: string;
2222
}
2323

src/v2/providers/alerts/crashlytics.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ interface Issue {
1515
* Payload is wrapped inside a FirebaseAlertData object.
1616
*/
1717
export interface NewFatalIssuePayload {
18-
['@type']: 'com.google.firebase.firebasealerts.CrashlyticsNewFatalIssuePayload';
18+
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.CrashlyticsNewFatalIssuePayload';
1919
issue: Issue;
2020
}
2121

@@ -24,7 +24,7 @@ export interface NewFatalIssuePayload {
2424
* Payload is wrapped inside a FirebaseAlertData object.
2525
*/
2626
export interface NewNonfatalIssuePayload {
27-
['@type']: 'com.google.firebase.firebasealerts.CrashlyticsNewNonfatalIssuePayload';
27+
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.CrashlyticsNewNonfatalIssuePayload';
2828
issue: Issue;
2929
}
3030

@@ -33,7 +33,7 @@ export interface NewNonfatalIssuePayload {
3333
* Payload is wrapped inside a FirebaseAlertData object.
3434
*/
3535
export interface RegressionAlertPayload {
36-
['@type']: 'com.google.firebase.firebasealerts.CrashlyticsRegressionAlertPayload';
36+
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.CrashlyticsRegressionAlertPayload';
3737
type: string;
3838
issue: Issue;
3939
resolveTime: string;
@@ -52,7 +52,7 @@ interface TrendingIssueDetails {
5252
* Payload is wrapped inside a FirebaseAlertData object.
5353
*/
5454
export interface StabilityDigestPayload {
55-
['@type']: 'com.google.firebase.firebasealerts.CrashlyticsStabilityDigestPayload';
55+
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.CrashlyticsStabilityDigestPayload';
5656
digestDate: string;
5757
trendingIssues: TrendingIssueDetails[];
5858
}
@@ -62,7 +62,7 @@ export interface StabilityDigestPayload {
6262
* Payload is wrapped inside a FirebaseAlertData object.
6363
*/
6464
export interface VelocityAlertPayload {
65-
['@type']: 'com.google.firebase.firebasealerts.VelocityAlertPayload';
65+
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.CrashlyticsVelocityAlertPayload';
6666
issue: Issue;
6767
createTime: string;
6868
crashCount: number;
@@ -75,7 +75,7 @@ export interface VelocityAlertPayload {
7575
* Payload is wrapped inside a FirebaseAlertData object.
7676
*/
7777
export interface NewAnrIssuePayload {
78-
['@type']: 'com.google.firebase.firebasealerts.NewAnrIssuePayload';
78+
['@type']: 'type.googleapis.com/google.events.firebase.firebasealerts.v1.CrashlyticsNewAnrIssuePayload';
7979
issue: Issue;
8080
}
8181

0 commit comments

Comments
 (0)