Analytics: rename 'event.data.date' to 'event.data.reportingDate' (#122)

Author: Robert-Jan Huijsman

spec/providers/analytics.spec.input.ts

@@ -125,7 +125,7 @@ export const fullPayload = JSON.parse(`{
 
 // The event data that we expect would be constructed if the payload above were to arrive.
 export const fullEventData: AnalyticsEvent = {
-  date: '20170202',
+  reportingDate: '20170202',
   name: 'Loaded_In_Background',
   params: {
     build: '1350',

spec/providers/analytics.spec.ts

@@ -116,7 +116,7 @@ describe('AnalyticsEventBuilder', () => {
       };
 
       return expect(cloudFunction(event)).to.eventually.deep.equal({
-        date: '20170202',
+        reportingDate: '20170202',
         name: 'Loaded_In_Background',
         params: {
           build: '1350',
@@ -163,7 +163,7 @@ describe('AnalyticsEventBuilder', () => {
       };
 
       return expect(cloudFunction(event)).to.eventually.deep.equal({
-        date: '20170202',
+        reportingDate: '20170202',
         name: 'Loaded_In_Background',
         params: {},
         logTime: '2017-03-09T17:30:00.000Z',
@@ -214,7 +214,7 @@ describe('AnalyticsEventBuilder', () => {
       };
 
       return expect(cloudFunction(event)).to.eventually.deep.equal({
-        date: '20170202',
+        reportingDate: '20170202',
         name: 'Loaded_In_Background',
         params: {},
         valueInUSD: 123.4,  // Field renamed Usd -> USD.

src/providers/analytics.ts

@@ -240,7 +240,7 @@ export class AnalyticsEvent {
   /** The date on which the event.was logged.
    *  (YYYYMMDD format in the registered timezone of your app.)
    */
-  date: string;
+  reportingDate: string;
 
   /** The name of the event. */
   name: string;
@@ -269,9 +269,10 @@ export class AnalyticsEvent {
     if (wireFormat.eventDim && wireFormat.eventDim.length > 0) {
       // If there's an eventDim, there'll always be exactly one.
       let eventDim = wireFormat.eventDim[0];
-      copyFields(eventDim, this, ['date', 'name']);
+      copyField(eventDim, this, 'name');
       copyField(eventDim, this, 'params', p => _.mapValues(p, unwrapValue));
       copyFieldTo(eventDim, this, 'valueInUsd', 'valueInUSD');
+      copyFieldTo(eventDim, this, 'date', 'reportingDate');
       copyTimestampToString(eventDim, this, 'timestampMicros', 'logTime');
       copyTimestampToString(eventDim, this, 'previousTimestampMicros', 'previousLogTime');
     }