Mark vpc connector as accepting string param type (#1329)

Berlioz · web-flow · commit aae1abd55930 · 2022-12-27T22:03:02.000-08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1 @@
+- Allow Functions to specify vpcConnector as a string parameter (#1329)
diff --git a/src/v1/function-configuration.ts b/src/v1/function-configuration.ts
@@ -205,7 +205,7 @@ export interface RuntimeOptions {
   /**
    * Connect cloud function to specified VPC connector.
    */
-  vpcConnector?: string | ResetValue;
+  vpcConnector?: string | Expression<string> | ResetValue;
 
   /**
    * Egress settings for VPC connector.
diff --git a/src/v2/options.ts b/src/v2/options.ts
@@ -162,7 +162,7 @@ export interface GlobalOptions {
   /**
    * Connect cloud function to specified VPC connector.
    */
-  vpcConnector?: string | ResetValue;
+  vpcConnector?: string | Expression<string> | ResetValue;
 
   /**
    * Egress settings for VPC connector.
diff --git a/src/v2/providers/alerts/alerts.ts b/src/v2/providers/alerts/alerts.ts
@@ -151,7 +151,7 @@ export interface FirebaseAlertOptions extends options.EventHandlerOptions {
    * Connect cloud function to specified VPC connector.
    * A value of null removes the VPC connector
    */
-  vpcConnector?: string | ResetValue;
+  vpcConnector?: string | Expression<string> | ResetValue;
 
   /**
    * Egress settings for VPC connector.
diff --git a/src/v2/providers/alerts/appDistribution.ts b/src/v2/providers/alerts/appDistribution.ts
@@ -165,7 +165,7 @@ export interface AppDistributionOptions extends options.EventHandlerOptions {
   /**
    * Connect cloud function to specified VPC connector.
    */
-  vpcConnector?: string | ResetValue;
+  vpcConnector?: string | Expression<string> | ResetValue;
 
   /**
    * Egress settings for VPC connector.
diff --git a/src/v2/providers/alerts/crashlytics.ts b/src/v2/providers/alerts/crashlytics.ts
@@ -245,7 +245,7 @@ export interface CrashlyticsOptions extends options.EventHandlerOptions {
   /**
    * Connect cloud function to specified VPC connector.
    */
-  vpcConnector?: string | ResetValue;
+  vpcConnector?: string | Expression<string> | ResetValue;
 
   /**
    * Egress settings for VPC connector.
diff --git a/src/v2/providers/database.ts b/src/v2/providers/database.ts
@@ -166,7 +166,7 @@ export interface ReferenceOptions<Ref extends string = string> extends options.E
   /**
    * Connect cloud function to specified VPC connector.
    */
-  vpcConnector?: string | ResetValue;
+  vpcConnector?: string | Expression<string> | ResetValue;
 
   /**
    * Egress settings for VPC connector.
diff --git a/src/v2/providers/eventarc.ts b/src/v2/providers/eventarc.ts
@@ -130,7 +130,7 @@ export interface EventarcTriggerOptions extends options.EventHandlerOptions {
   /**
    * Connect cloud function to specified VPC connector.
    */
-  vpcConnector?: string | ResetValue;
+  vpcConnector?: string | Expression<string> | ResetValue;
 
   /**
    * Egress settings for VPC connector.
diff --git a/src/v2/providers/https.ts b/src/v2/providers/https.ts
@@ -123,7 +123,7 @@ export interface HttpsOptions extends Omit<GlobalOptions, "region"> {
   /**
    * Connect cloud function to specified VPC connector.
    */
-  vpcConnector?: string | ResetValue;
+  vpcConnector?: string | Expression<string> | ResetValue;
 
   /**
    * Egress settings for VPC connector.
diff --git a/src/v2/providers/identity.ts b/src/v2/providers/identity.ts
@@ -132,7 +132,7 @@ export interface BlockingOptions {
   /**
    * Connect cloud function to specified VPC connector.
    */
-  vpcConnector?: string | ResetValue;
+  vpcConnector?: string | Expression<string> | ResetValue;
 
   /**
    * Egress settings for VPC connector.
diff --git a/src/v2/providers/pubsub.ts b/src/v2/providers/pubsub.ts
@@ -223,7 +223,7 @@ export interface PubSubOptions extends options.EventHandlerOptions {
   /**
    * Connect cloud function to specified VPC connector.
    */
-  vpcConnector?: string | ResetValue;
+  vpcConnector?: string | Expression<string> | ResetValue;
 
   /**
    * Egress settings for VPC connector.
diff --git a/src/v2/providers/storage.ts b/src/v2/providers/storage.ts
@@ -271,7 +271,7 @@ export interface StorageOptions extends options.EventHandlerOptions {
   /**
    * Connect cloud function to specified VPC connector.
    */
-  vpcConnector?: string | ResetValue;
+  vpcConnector?: string | Expression<string> | ResetValue;
 
   /**
    * Egress settings for VPC connector.
diff --git a/src/v2/providers/tasks.ts b/src/v2/providers/tasks.ts
@@ -128,7 +128,7 @@ export interface TaskQueueOptions extends options.EventHandlerOptions {
   /**
    * Connect cloud function to specified VPC connector.
    */
-  vpcConnector?: string | ResetValue;
+  vpcConnector?: string | Expression<string> | ResetValue;
 
   /**
    * Egress settings for VPC connector.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+- Allow Functions to specify vpcConnector as a string parameter (#1329)`