prettier to enforce pareens in arrow functions (#474)

Author: thechenky

.prettierrc

@@ -1,4 +1,5 @@
 {
+  "arrowParens": "always",
   "singleQuote": true,
   "trailingComma": "es5"
 }

integration_test/functions/src/database-tests.ts

@@ -24,14 +24,14 @@ export const databaseTests: any = functions.database
         (change, context) => !(context as any).app
       )
 
-      .it('should give refs access to admin data', change =>
+      .it('should give refs access to admin data', (change) =>
         change.after.ref.parent
           .child('adminOnly')
           .update({ allowed: 1 })
           .then(() => true)
       )
 
-      .it('should have a correct ref url', change => {
+      .it('should have a correct ref url', (change) => {
         const url = change.after.ref.toString();
         return Promise.resolve()
           .then(() => {

integration_test/functions/src/firestore-tests.ts

@@ -15,7 +15,7 @@ export const firestoreTests: any = functions
 
       .it('should not have event.app', (snap, context) => !(context as any).app)
 
-      .it('should give refs write access', snap =>
+      .it('should give refs write access', (snap) =>
         snap.ref.set({ allowed: 1 }, { merge: true }).then(() => true)
       )
 

integration_test/functions/src/https-tests.ts

@@ -2,9 +2,9 @@ import * as functions from 'firebase-functions';
 import * as _ from 'lodash';
 import { TestSuite, expectEq } from './testing';
 
-export const callableTests: any = functions.https.onCall(d => {
+export const callableTests: any = functions.https.onCall((d) => {
   return new TestSuite('https onCall')
-    .it('should have the correct data', data =>
+    .it('should have the correct data', (data) =>
       expectEq(_.get(data, 'foo'), 'bar')
     )
     .run(d.testId, d);

integration_test/functions/src/index.ts

@@ -32,9 +32,9 @@ function callHttpsTrigger(name: string, data: any, baseUrl) {
           'Content-Type': 'application/json',
         },
       },
-      response => {
+      (response) => {
         let body = '';
-        response.on('data', chunk => {
+        response.on('data', (chunk) => {
           body += chunk;
         });
         response.on('end', () => resolve(body));
@@ -59,9 +59,9 @@ function callScheduleTrigger(functionName: string, region: string) {
           'Content-Type': 'application/json',
         },
       },
-      response => {
+      (response) => {
         let body = '';
-        response.on('data', chunk => {
+        response.on('data', (chunk) => {
           body += chunk;
         });
         response.on('end', () => resolve(body));
@@ -114,7 +114,7 @@ export const integrationTests: any = functions
           password: 'secret',
           displayName: `${testId}`,
         })
-        .then(userRecord => {
+        .then((userRecord) => {
           // A user deletion to trigger the Firebase Auth user deletion tests.
           admin.auth().deleteUser(userRecord.uid);
         }),
@@ -160,7 +160,7 @@ export const integrationTests: any = functions
         let ref = admin.database().ref(`testRuns/${testId}`);
         return new Promise((resolve, reject) => {
           let testsExecuted = 0;
-          ref.on('child_added', snapshot => {
+          ref.on('child_added', (snapshot) => {
             testsExecuted += 1;
             if (snapshot.key != 'timestamp' && !snapshot.val().passed) {
               reject(
@@ -185,7 +185,7 @@ export const integrationTests: any = functions
             ref.off(); // No more need to listen.
             return Promise.resolve();
           })
-          .catch(err => {
+          .catch((err) => {
             ref.off(); // No more need to listen.
             return Promise.reject(err);
           });
@@ -194,7 +194,7 @@ export const integrationTests: any = functions
         console.log('All tests pass!');
         resp.status(200).send('PASS \n');
       })
-      .catch(err => {
+      .catch((err) => {
         console.log(`Some tests failed: ${err}`);
         resp
           .status(500)

integration_test/functions/src/pubsub-tests.ts

@@ -43,7 +43,7 @@ export const pubsubTests: any = functions.pubsub
         expectEq((context as any).action, undefined)
       )
 
-      .it('should have pubsub data', message => {
+      .it('should have pubsub data', (message) => {
         const decoded = new Buffer(message.data, 'base64').toString();
         const parsed = JSON.parse(decoded);
         return evaluate(
@@ -52,7 +52,7 @@ export const pubsubTests: any = functions.pubsub
         );
       })
 
-      .it('should decode JSON payloads with the json helper', message =>
+      .it('should decode JSON payloads with the json helper', (message) =>
         evaluate(message.json.hasOwnProperty('testId'), message.json)
       )
 
@@ -62,15 +62,15 @@ export const pubsubTests: any = functions.pubsub
 export const schedule: any = functions.pubsub
   .schedule('every 10 hours') // This is a dummy schedule, since we need to put a valid one in.
   // For the test, the job is triggered by the jobs:run api
-  .onRun(context => {
+  .onRun((context) => {
     let testId;
     let db = admin.database();
     return new Promise(async (resolve, reject) => {
       await db
         .ref('testRuns')
         .orderByChild('timestamp')
         .limitToLast(1)
-        .on('value', snap => {
+        .on('value', (snap) => {
           testId = Object.keys(snap.val())[0];
           new TestSuite('pubsub scheduleOnRun')
             .it('should trigger when the scheduler fires', () => success())

integration_test/functions/src/testing.ts

@@ -28,22 +28,22 @@ export class TestSuite<T> {
       const run = Promise.resolve()
         .then(() => this.tests[testName](data, context))
         .then(
-          result => {
+          (result) => {
             console.log(
               `${result ? 'Passed' : 'Failed with successful op'}: ${testName}`
             );
             return { name: testName, passed: !!result };
           },
-          error => {
+          (error) => {
             console.error(`Failed: ${testName}`, error);
             return { name: testName, passed: 0, error: error };
           }
         );
       running.push(run);
     }
-    return Promise.all(running).then(results => {
+    return Promise.all(running).then((results) => {
       let sum = 0;
-      results.forEach(val => (sum = sum + val.passed));
+      results.forEach((val) => (sum = sum + val.passed));
       const summary = `passed ${sum} of ${running.length}`;
       const passed = sum === running.length;
       console.log(summary);

spec/apps.spec.ts

@@ -38,7 +38,7 @@ describe('apps', () => {
   });
 
   afterEach(() => {
-    _.forEach(firebase.apps, app => {
+    _.forEach(firebase.apps, (app) => {
       app.delete();
     });
   });

spec/cloud-functions.spec.ts

@@ -118,7 +118,7 @@ describe('makeCloudFunction', () => {
       data: 'test data',
     };
 
-    return cf(test.data, test.context).then(result => {
+    return cf(test.data, test.context).then((result) => {
       expect(result).to.deep.equal({
         eventId: '00000',
         timestamp: '2016-11-04T21:29:03.496Z',

spec/function-builder.spec.ts

@@ -37,7 +37,7 @@ describe('FunctionBuilder', () => {
     const fn = functions
       .region('us-east1')
       .auth.user()
-      .onCreate(user => user);
+      .onCreate((user) => user);
 
     expect(fn.__trigger.regions).to.deep.equal(['us-east1']);
   });
@@ -46,7 +46,7 @@ describe('FunctionBuilder', () => {
     const fn = functions
       .region('us-east1', 'us-central1')
       .auth.user()
-      .onCreate(user => user);
+      .onCreate((user) => user);
 
     expect(fn.__trigger.regions).to.deep.equal(['us-east1', 'us-central1']);
   });
@@ -62,7 +62,7 @@ describe('FunctionBuilder', () => {
         'asia-northeast1'
       )
       .auth.user()
-      .onCreate(user => user);
+      .onCreate((user) => user);
 
     expect(fn.__trigger.regions).to.deep.equal([
       'us-central1',
@@ -81,7 +81,7 @@ describe('FunctionBuilder', () => {
         memory: '256MB',
       })
       .auth.user()
-      .onCreate(user => user);
+      .onCreate((user) => user);
 
     expect(fn.__trigger.availableMemoryMb).to.deep.equal(256);
     expect(fn.__trigger.timeout).to.deep.equal('90s');
@@ -95,7 +95,7 @@ describe('FunctionBuilder', () => {
         memory: '256MB',
       })
       .auth.user()
-      .onCreate(user => user);
+      .onCreate((user) => user);
 
     expect(fn.__trigger.regions).to.deep.equal(['europe-west2']);
     expect(fn.__trigger.availableMemoryMb).to.deep.equal(256);
@@ -110,7 +110,7 @@ describe('FunctionBuilder', () => {
       })
       .region('europe-west1')
       .auth.user()
-      .onCreate(user => user);
+      .onCreate((user) => user);
 
     expect(fn.__trigger.regions).to.deep.equal(['europe-west1']);
     expect(fn.__trigger.availableMemoryMb).to.deep.equal(256);