Skip to content

Commit 3f1cdd8

Browse files
merlinnotthechenky
authored andcommitted
Run Prettier for all supported file formats (#509)
* Run Prettier for all supported file formats * Reformat all files * formatter fixes
1 parent 6b0d234 commit 3f1cdd8

File tree

9 files changed

+24
-25
lines changed

9 files changed

+24
-25
lines changed

.github/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ All submissions, including submissions by project members, require review. We
2121
use GitHub pull requests for this purpose. Consult [GitHub Help] for more
2222
information on using pull requests.
2323

24-
[GitHub Help]: https://help.github.com/articles/about-pull-requests/
24+
[github help]: https://help.github.com/articles/about-pull-requests/

.github/ISSUE_TEMPLATE/---feature-request.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
---
22
name: "\U0001F4A1 Feature Request"
3-
about: Have a feature you'd like to see in the functions SDK? Request it through our
3+
about:
4+
Have a feature you'd like to see in the functions SDK? Request it through our
45
support channel.
56
title: ''
67
labels: ''
78
assignees: ''
89
---
9-
<!-- DO NOT DELETE
10+
11+
<!-- DO NOT DELETE
1012
validate_template=false
1113
template_path=.github/ISSUE_TEMPLATE/---feature-request.md
1214
-->

.github/ISSUE_TEMPLATE/---report-a-bug.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
---
2-
name: "⚠️ Report a Bug"
2+
name: '⚠️ Report a Bug'
33
about: Think you found a bug in the SDK? Report it here.
44
title: ''
55
labels: ''
66
assignees: ''
7-
87
---
9-
<!-- DO NOT DELETE
8+
9+
<!-- DO NOT DELETE
1010
validate_template=true
1111
template_path=.github/ISSUE_TEMPLATE/---report-a-bug.md
1212
-->
@@ -21,11 +21,13 @@ template_path=.github/ISSUE_TEMPLATE/---report-a-bug.md
2121
be fixed in the latest versions. -->
2222

2323
**node:**
24+
2425
<!-- Run node --version and print the output here-->
2526

2627
**firebase-functions:**
2728

2829
**firebase-tools:**
30+
2931
<!-- Run firebase --version and print the output here-->
3032

3133
**firebase-admin:**
@@ -34,17 +36,14 @@ be fixed in the latest versions. -->
3436

3537
<!-- Provide a minimal, complete, and verifiable example (http://stackoverflow.com/help/mcve) -->
3638

37-
3839
### [REQUIRED] Steps to reproduce
3940

4041
<!-- Provide the steps needed to reproduce the issue given the above test case. -->
4142

42-
4343
### [REQUIRED] Expected behavior
4444

4545
<!-- What is the expected behavior? -->
4646

47-
4847
### [REQUIRED] Actual behavior
4948

5049
<!-- Please copy and paste any error logs from https://console.firebase.google.com/project/_/functions/logs.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ and make note of the following:
55
66
Run the linter and test suite
77
==============================
8-
Run `npm test` to make sure your changes compile properly and the tests all pass on your local machine.
9-
We've hooked up this repo with continuous integration to double check those things for you.
8+
Run `npm test` to make sure your changes compile properly and the tests all pass on your local machine.
9+
We've hooked up this repo with continuous integration to double check those things for you.
1010
1111
Add tests (if applicable)
1212
==============================
@@ -20,12 +20,11 @@ before sending PRs. We cannot accept code without this.
2020
2121
-->
2222

23-
2423
### Description
2524

2625
<!-- Are you fixing a bug? Implementing a new feature? Make sure we have the context around your change.
2726
Link to other relevant issues or pull requests. -->
2827

2928
### Code sample
3029

31-
<!-- Proposing an API change? Provide code samples showing how the API will be used. -->
30+
<!-- Proposing an API change? Provide code samples showing how the API will be used. -->

.prettierignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
lib
2+
package.json
3+
spec/fixtures/credential/unparsable.key.json

integration_test/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
How to Use
2-
---------
1+
## How to Use
32

4-
***ATTENTION***: Running this test will wipe the contents of the Firebase project(s) you run it against. Make sure you use disposable Firebase project(s)!
3+
**_ATTENTION_**: Running this test will wipe the contents of the Firebase project(s) you run it against. Make sure you use disposable Firebase project(s)!
54

65
Run the integration test as follows:
76

87
```bash
98
./run_tests.sh <project_id> [<project_id2>]
109
```
10+
1111
If just one project_id is provided, the both the node6 and node8 tests will be run on that project, in series. If two project_ids are provided, the node6 tests will be run on the first project and the node8 tests will be run on the second one, in parallel.
1212

1313
The tests run fully automatically, and will print the result on standard out. The integration test for HTTPS is that it properly kicks off other integration tests and returns a result. From there the other integration test suites will write their results back to the database, where you can check the detailed results if you'd like.

integration_test/functions/tsconfig.json

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@
66
"noImplicitAny": false,
77
"outDir": "lib",
88
"declaration": true,
9-
"typeRoots": [
10-
"node_modules/@types"
11-
]
9+
"typeRoots": ["node_modules/@types"]
1210
},
13-
"files": [
14-
"src/index.ts"
15-
]
11+
"files": ["src/index.ts"]
1612
}

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
"build:pack": "rm -rf lib && npm install && tsc -p tsconfig.release.json && npm pack",
2626
"build:release": "npm install --production && npm install typescript firebase-admin && tsc -p tsconfig.release.json",
2727
"build": "tsc -p tsconfig.release.json",
28-
"format": "prettier --check '**/*.ts'",
29-
"format:fix": "prettier --write '**/*.ts'",
28+
"format": "prettier --check '**/*.{json,md,ts,yml,yaml}'",
29+
"format:fix": "prettier --write '**/*.{json,md,ts,yml,yaml}'",
3030
"lint": "tslint --config tslint.json --project tsconfig.json ",
3131
"lint:fix": "tslint --config tslint.json --fix --project tsconfig.json",
3232
"test": "mocha -r ts-node/register ./spec/index.spec.ts"

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"compilerOptions": {
33
"resolveJsonModule": true,
4-
"sourceMap": true,
4+
"sourceMap": true
55
},
66
"extends": "./tsconfig.release.json",
77
"include": ["./src/**/*.ts", "./spec/**/*.ts"]

0 commit comments

Comments
 (0)