Fix database event.data.val() bug (#46)

* Fix bug where event.data.val() was returning array of nulls when database payload had a length property

Author: laurenzlong

spec/providers/database.spec.ts

@@ -137,6 +137,12 @@ describe('DeltaSnapshot', () => {
       populate({ myKey: 'foo', myOtherKey: 'bar' }, { myKey: null });
       expect(subject.val()).to.deep.equal({ myOtherKey: 'bar' });
     });
+
+    // Regression test: .val() was returning array of nulls when there's a property called length (BUG#37683995)
+    it('should return correct values when data has "length" property', () => {
+      populate(null, { length: 3,  foo: 'bar' });
+      expect(subject.val()).to.deep.equal({ length: 3, foo: 'bar'});
+    });
   });
 
   describe('#child(): DeltaSnapshot', () => {

src/providers/database.ts

@@ -248,7 +248,9 @@ export class DeltaSnapshot implements firebase.database.DataSnapshot {
     let numKeys = 0;
     let maxKey = 0;
     let allIntegerKeys = true;
-    _.forEach(node, (childNode, key) => {
+    for (let key in node) {
+      if (!node.hasOwnProperty(key)) { continue; }
+      let childNode = node[key];
       obj[key] = this._checkAndConvertToArray(childNode);
       numKeys++;
       const integerRegExp = /^(0|[1-9]\d*)$/;
@@ -257,7 +259,7 @@ export class DeltaSnapshot implements firebase.database.DataSnapshot {
       } else {
         allIntegerKeys = false;
       }
-    });
+    }
 
     if (allIntegerKeys && maxKey < 2 * numKeys) {
       // convert to array.