Fix auth UserRecord.metadata regression (#481)

* fix auth regression

* adding unit and integration tests to test the wire format conversion for auth

* add changelog for release

Author: thechenky

changelog.txt

@@ -0,0 +1 @@
+* Fixes bug where auth.UserRecord.metadata was undefined.

integration_test/functions/src/auth-tests.ts

@@ -32,6 +32,8 @@ export const createUserTests: any = functions.auth.user().onCreate((u, c) => {
       expectEq((context as any).action, undefined)
     )
 
+    .it('should have properly defined meta', (user, context) => user.metadata)
+
     .run(testId, u, c);
 });
 

spec/providers/auth.spec.ts

@@ -178,6 +178,21 @@ describe('Auth Functions', () => {
       const record = auth.userRecordConstructor(raw);
       expect(record.toJSON()).to.deep.equal(raw);
     });
+
+    it('will convert raw wire fields createdAt and lastSignedInAt to creationTime and lastSignInTime', () => {
+      const raw: any = {
+        uid: '123',
+        metadata: {
+          createdAt: '2017-02-02T23:06:26.124Z',
+          lastSignedInAt: '2017-02-02T23:01:19.797Z',
+        },
+      };
+      const record = auth.userRecordConstructor(raw);
+      expect(record.metadata).to.deep.equal({
+        creationTime: '2017-02-02T23:06:26.124Z',
+        lastSignInTime: '2017-02-02T23:01:19.797Z',
+      });
+    });
   });
 
   describe('handler namespace', () => {

src/providers/auth.ts

@@ -140,7 +140,10 @@ export function userRecordConstructor(
     _.set(
       record,
       'metadata',
-      new UserRecordMetadata(meta.creationTime, meta.lastSignInTime)
+      new UserRecordMetadata(
+        meta.createdAt || meta.creationTime,
+        meta.lastSignedInAt || meta.lastSignInTime
+      )
     );
   } else {
     _.set(record, 'metadata', new UserRecordMetadata(null, null));