Use process.env.PWD for finding .runtimeconfig.json (#634)

Author: laurenzlong

CHANGELOG.md

@@ -0,0 +1,4 @@
+**IMPORTANT: Please update to this version of `firebase-functions` if you are using Node.js 10 functions, otherwise your functions will break in production.**
+
+- Prevents deployment and runtime issues caused by upcoming changes to Cloud Functions infrastructure for Node.js 10 functions. (Issue #630)
+- Adds support for writing scheduled functions under handler namespace.

changelog.txt

@@ -25,6 +25,12 @@ import * as mockRequire from 'mock-require';
 import { config, firebaseConfig } from '../src/config';
 
 describe('config()', () => {
+  before(() => {
+    process.env.PWD = '/srv';
+  });
+  after(() => {
+    delete process.env.PWD;
+  });
   afterEach(() => {
     mockRequire.stopAll();
     delete config.singleton;
@@ -33,19 +39,19 @@ describe('config()', () => {
   });
 
   it('loads config values from .runtimeconfig.json', () => {
-    mockRequire('../../../.runtimeconfig.json', { foo: 'bar', firebase: {} });
+    mockRequire('/srv/.runtimeconfig.json', { foo: 'bar', firebase: {} });
     const loaded = config();
     expect(loaded).to.not.have.property('firebase');
     expect(loaded).to.have.property('foo', 'bar');
   });
 
   it('does not provide firebase config if .runtimeconfig.json not invalid', () => {
-    mockRequire('../../../.runtimeconfig.json', 'does-not-exist');
+    mockRequire('/srv/.runtimeconfig.json', 'does-not-exist');
     expect(firebaseConfig()).to.be.null;
   });
 
   it('does not provide firebase config if .ruuntimeconfig.json has no firebase property', () => {
-    mockRequire('../../../.runtimeconfig.json', {});
+    mockRequire('/srv/.runtimeconfig.json', {});
     expect(firebaseConfig()).to.be.null;
   });
 

spec/config.spec.ts

@@ -21,6 +21,7 @@
 // SOFTWARE.
 
 import * as firebase from 'firebase-admin';
+import * as path from 'path';
 
 export function config(): config.Config {
   if (typeof config.singleton === 'undefined') {
@@ -68,9 +69,10 @@ export function firebaseConfig(): firebase.AppOptions | null {
 
   // Could have Runtime Config with Firebase in it as an ENV location or default.
   try {
-    const path =
-      process.env.CLOUD_RUNTIME_CONFIG || '../../../.runtimeconfig.json';
-    const config = require(path);
+    const configPath =
+      process.env.CLOUD_RUNTIME_CONFIG ||
+      path.join(process.env.PWD, '.runtimeconfig.json');
+    const config = require(configPath);
     if (config.firebase) {
       return config.firebase;
     }
@@ -92,9 +94,10 @@ function init() {
   }
 
   try {
-    const path =
-      process.env.CLOUD_RUNTIME_CONFIG || '../../../.runtimeconfig.json';
-    const parsed = require(path);
+    const configPath =
+      process.env.CLOUD_RUNTIME_CONFIG ||
+      path.join(process.env.PWD, '.runtimeconfig.json');
+    const parsed = require(configPath);
     delete parsed.firebase;
     config.singleton = parsed;
     return;