Skip to content

Commit 22a8ac2

Browse files
authored
Merge pull request #102 from FirebasePrivate/inlined.fix-kluge
Update dependency on firebase-admin to get the latest types
2 parents 4845858 + 1591a9b commit 22a8ac2

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

.npmignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
.tmp
22
coverage
33
.vscode
4+
.idea
45
tsconfig.*
56
tslint.*
7+
.travis.yml
68

79
# Don't include the raw typescript
810
src

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
"@types/sinon": "^1.16.29",
3737
"chai": "^3.5.0",
3838
"chai-as-promised": "^5.2.0",
39-
"firebase-admin": "^4.0.5",
39+
"firebase-admin": "^4.1.1",
4040
"istanbul": "^0.4.2",
4141
"mocha": "^2.4.5",
4242
"mock-require": "^2.0.1",
@@ -46,7 +46,7 @@
4646
"typescript": "^2.0.3"
4747
},
4848
"peerDependencies": {
49-
"firebase-admin": "^4.0.5"
49+
"firebase-admin": "^4.1.1"
5050
},
5151
"dependencies": {
5252
"@types/express": "^4.0.33",

src/config.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,7 @@ export function config(): config.Config {
3535
export namespace config {
3636
// Config type is usable as a object (dot notation allowed), and firebase
3737
// property will also code complete.
38-
export type Config = Object & {
39-
firebase?: firebase.AppOptions & {
40-
// NOTE: firebase-admin currently only defines app options for features it exposes, not the full set
41-
// of firebase features. This shim can be removed in the next version of firebase-admin.
42-
storageBucket: string,
43-
}
44-
};
38+
export type Config = Object & { firebase?: firebase.AppOptions };
4539

4640
/** @internal */
4741
export let singleton: config.Config;

0 commit comments

Comments
 (0)