Analytics: remove ltvInfo and trafficSource fields from the public interface (#132)

The ltvInUSD and trafficSource fields aren't carried in the payload even though the proto permits them to be there.

Author: Robert-Jan Huijsman

spec/providers/analytics.spec.input.ts

@@ -152,11 +152,6 @@ export const fullEvent: Event<AnalyticsEvent> = {
         appStore: 'iTunes',
         appVersion: '5.2.0',
       },
-      trafficSource: {
-        userAcquiredSource: 'Pizza Everywhere',
-        userAcquiredCampaign: 'Functions launch party',
-        userAcquiredMedium: 'Free food',
-      },
       bundleInfo: {
         bundleSequenceId: 6034,
         serverTimestampOffset: 371,
@@ -195,7 +190,6 @@ export const fullEvent: Event<AnalyticsEvent> = {
           value: '5.2.0',
         },
       },
-      ltvInUSD: 133.7,
     },
   },
 };

spec/providers/analytics.spec.ts

@@ -204,12 +204,6 @@ describe('AnalyticsEventBuilder', () => {
               valueInUsd: 123.4,
             },
           ],
-          userDim: {
-            ltvInfo: {
-              revenue: 987.6,
-              currency: 'USD',
-            },
-          },
         },
       };
 
@@ -218,10 +212,6 @@ describe('AnalyticsEventBuilder', () => {
         name: 'Loaded_In_Background',
         params: {},
         valueInUSD: 123.4,  // Field renamed Usd -> USD.
-        user: {
-          ltvInUSD: 987.6,  // USD value extracted.
-          userProperties: {},
-        },
       });
     });
 

src/providers/analytics.ts

@@ -140,28 +140,19 @@ export class UserDimensions {
   /** App information. */
   appInfo?: AppInfo;
 
-  /** Information about the marketing campaign which acquired the user. */
-  trafficSource?: TrafficSource;
-
   /** Information regarding the bundle in which these events were uploaded. */
   bundleInfo: ExportBundleInfo;
 
-  /** Lifetime Value revenue of this user, in USD. */
-  ltvInUSD?: number;
-
   /** @internal */
   constructor(wireFormat: any) {
     // These are interfaces or primitives, no transformation needed.
-    copyFields(wireFormat, this, ['userId', 'deviceInfo', 'geoInfo', 'appInfo', 'trafficSource']);
+    copyFields(wireFormat, this, ['userId', 'deviceInfo', 'geoInfo', 'appInfo']);
 
     // The following fields do need transformations of some sort.
     copyTimestampToString(wireFormat, this, 'firstOpenTimestampMicros', 'firstOpenTime');
     this.userProperties = {};  // With no entries in the wire format, present an empty (as opposed to absent) map.
     copyField(wireFormat, this, 'userProperties', r => _.mapValues(r, p => new UserPropertyValue(p)));
     copyField(wireFormat, this, 'bundleInfo', r => new ExportBundleInfo(r));
-    if (wireFormat.ltvInfo && wireFormat.ltvInfo.currency === 'USD') {
-      this.ltvInUSD = wireFormat.ltvInfo.revenue;
-    }
 
     // BUG(36000368) Remove when no longer necessary
     /* tslint:disable:no-string-literal */