Add another fallback for snpashot not including a read time (#923)

* Add another fallback for snpashot not including a read time

* run formtter/linter

Author: inlined

src/logger/index.ts

@@ -36,7 +36,7 @@ function removeCircular(obj: any, refs: any[] = []): any {
     return obj;
   }
   // If the object defines its own toJSON, prefer that.
-  if (obj['toJSON']) {
+  if (obj.toJSON) {
     return obj.toJSON();
   }
   if (refs.includes(obj)) {

src/v1/providers/firestore.ts

@@ -22,7 +22,9 @@
 
 import * as firebase from 'firebase-admin';
 import * as _ from 'lodash';
+
 import { posix } from 'path';
+import * as logger from '../../logger';
 import { apps } from '../apps';
 import {
   Change,
@@ -155,9 +157,15 @@ export function snapshotConstructor(event: Event): DocumentSnapshot {
     event.context.resource.name,
     'value'
   );
-  const timeString =
+  let timeString =
     _.get(event, 'data.value.readTime') ??
     _.get(event, 'data.value.updateTime');
+
+  if (!timeString) {
+    logger.warn('Snapshot has no readTime. Using now()');
+    timeString = new Date().toISOString();
+  }
+
   const readTime = dateToTimestampProto(timeString);
   return firestoreInstance.snapshot_(valueProto, readTime, 'json');
 }

src/v2/index.ts

@@ -20,8 +20,8 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
-import * as https from './providers/https';
 import * as logger from '../logger';
+import * as https from './providers/https';
 
 export { https, logger };
 

src/v2/options.ts

@@ -24,9 +24,9 @@ import {
   durationFromSeconds,
   serviceAccountFromShorthand,
 } from '../common/encoding';
+import { convertIfPresent, copyIfPresent } from '../common/encoding';
 import * as logger from '../logger';
 import { TriggerAnnotation } from './base';
-import { copyIfPresent, convertIfPresent } from '../common/encoding';
 
 /**
  * List of all regions supported by Cloud Functions v2