addressed code review comments

Author: vimanyu

app/src/app_common.cc

@@ -88,8 +88,10 @@ const char* kCpuArchitecture = "arm32";
 
 #elif defined(__APPLE__)
 const char* kCppRuntimeOrStl = "libcpp";
-#if FIREBASE_PLATFORM_IOS || FIREBASE_PLATFORM_TVOS
+#if FIREBASE_PLATFORM_IOS
 const char* kOperatingSystem = "ios";
+#elif FIREBASE_PLATFORM_TVOS
+const char* kOperatingSystem = "tvos";
 #elif FIREBASE_PLATFORM_OSX
 const char* kOperatingSystem = "darwin";
 #else

auth/src/ios/credential_ios.mm

@@ -58,7 +58,7 @@ @implementation PhoneListenerDataObjC
 namespace firebase {
 namespace auth {
 
-static const char* kMockVerificationId = "mock verification id";
+static const char* kMockVerificationId = "PhoneAuth not supported on this platform";
 
 using util::StringFromNSString;
 
@@ -507,7 +507,7 @@ void ReauthenticateWithProviderGetCredentialCallback(FIRAuthCredential* _Nullabl
   #else // non-iOS Apple platforms (eg: tvOS)
   Future<SignInResult> future = MakeFuture(&futures, handle);
   futures.Complete(handle, kAuthErrorApiNotAvailable,
-    "Link with getCredentialWithUIDelegate is not supported on non-iOS Apple platforms.");
+    "OAuth provider linking is not supported on non-iOS Apple platforms.");
   #endif // FIREBASE_PLATFORM_IOS
 
 }
@@ -544,7 +544,7 @@ void ReauthenticateWithProviderGetCredentialCallback(FIRAuthCredential* _Nullabl
   #else // non-iOS Apple platforms (eg: tvOS)
   Future<SignInResult> future = MakeFuture(&futures, handle);
   futures.Complete(handle, kAuthErrorApiNotAvailable,
-    "Reauthenticate with getCredentialWithUIDelegate is not supported on non-iOS Apple platforms.");
+    "OAuth reauthentication is not supported on non-iOS Apple platforms.");
   #endif // FIREBASE_PLATFORM_IOS
 }
 

build_scripts/tvos/build.sh

@@ -1,7 +1,7 @@
 #!/bin/bash -e
 #
 # Script to build iOS XCFrameworks
-# If built for all architectures (arm64 armv7 x86_64 i386),
+# If built for all architectures (arm64 x86_64),
 # it will build universal framework as well
 #
 

build_scripts/tvos/install_prereqs.sh

@@ -1,7 +1,7 @@
 #!/bin/bash -e
 
 if [[ $(uname) != "Darwin" ]]; then
-    echo "Unsupported platform, iOS can only be build on a MacOS machine."
+    echo "Unsupported platform, tvOS can only be build on a MacOS machine."
     exit 1
 fi
 

build_scripts/tvos/package.sh

@@ -1,4 +1,7 @@
 #!/bin/bash -e
+#
+# Script to package tvOS XCFrameworks.
+#
 
 builtpath=$1
 packagepath=$2

cmake/toolchains/apple.toolchain.cmake

@@ -1,3 +1,17 @@
+# Copyright 2021 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 # This file is part of the ios-cmake project. It was retrieved from
 # https://github.com/gerstrong/ios-cmake.git which is a fork of
 # https://github.com/cristeab/ios-cmake.git, which again is a fork of